Skip to content

feat: support break and continue in for loops#4124

Draft
Madoshakalaka wants to merge 1 commit intomasterfrom
break-continue
Draft

feat: support break and continue in for loops#4124
Madoshakalaka wants to merge 1 commit intomasterfrom
break-continue

Conversation

@Madoshakalaka
Copy link
Copy Markdown
Member

@Madoshakalaka Madoshakalaka commented Apr 9, 2026

Description

surprisingly simple after #4118 has landed.

Checklist

  • I have reviewed my own code
  • I have added tests

@Madoshakalaka Madoshakalaka added the A-yew-macro Area: The yew-macro crate label Apr 9, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

Visit the preview URL for this PR (updated for commit ee86510):

https://yew-rs-api--pr4124-break-continue-fls868so.web.app

(expires Thu, 16 Apr 2026 16:48:50 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

Size Comparison

Details
examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 100.017 100.017 0 0.000%
boids 163.845 163.845 0 0.000%
communication_child_to_parent 93.444 93.444 0 0.000%
communication_grandchild_with_grandparent 105.427 105.427 0 0.000%
communication_grandparent_to_grandchild 101.781 101.781 0 0.000%
communication_parent_to_child 90.855 90.855 0 0.000%
contexts 105.668 105.668 0 0.000%
counter 85.704 85.704 0 0.000%
counter_functional 87.716 87.716 0 0.000%
dyn_create_destroy_apps 89.594 89.594 0 0.000%
file_upload 99.037 99.037 0 0.000%
function_delayed_input 94.333 94.333 0 0.000%
function_memory_game 169.477 169.464 -0.013 -0.007%
function_router 398.580 398.571 -0.009 -0.002%
function_todomvc 164.129 164.186 +0.057 +0.035%
futures 234.856 234.856 0 0.000%
game_of_life 100.419 100.419 0 0.000%
immutable 258.715 258.715 0 0.000%
inner_html 80.548 80.548 0 0.000%
js_callback 109.251 109.251 0 0.000%
keyed_list 175.879 175.879 0 0.000%
mount_point 83.917 83.917 0 0.000%
nested_list 112.779 112.779 0 0.000%
node_refs 91.431 91.431 0 0.000%
password_strength 1718.531 1718.531 0 0.000%
portals 93.072 93.072 0 0.000%
router 365.322 365.304 -0.019 -0.005%
suspense 113.134 113.134 0 0.000%
timer 88.288 88.288 0 0.000%
timer_functional 98.746 98.746 0 0.000%
todomvc 141.281 141.281 0 0.000%
two_apps 85.889 85.889 0 0.000%
web_worker_fib 136.013 136.013 0 0.000%
web_worker_prime 184.398 184.398 0 0.000%
webgl 82.690 82.690 0 0.000%

✅ None of the examples has changed their size significantly.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

Benchmark - SSR

Yew Master

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 291.227 291.806 291.435 0.169
Hello World 10 501.681 505.884 503.363 1.249
Function Router 10 31280.080 31955.804 31599.583 195.873
Concurrent Task 10 1005.726 1007.690 1007.060 0.617
Many Providers 10 1128.978 1180.891 1150.370 18.207

Pull Request

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 291.344 297.317 292.321 1.825
Hello World 10 486.637 495.066 490.802 2.708
Function Router 10 31610.916 31939.906 31753.533 115.042
Concurrent Task 10 1006.423 1007.886 1007.210 0.507
Many Providers 10 1110.229 1155.943 1133.009 14.245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-yew-macro Area: The yew-macro crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant