Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Pull Request
📋 Description
This PR addresses two main issues:
Fixes the automatic translation script (
translate-locales.js):fetch is not definederror in Node.js 16 environments by adding a polyfill.Refines Bucket Permission Control:
pages/buckets/[key].vueto move from a coarseisAdmincheck to a fine-grained permission model usingusePermissions.isAdmin): Full access.consoleAdminpolicy): Full access via policy.console:BucketLifecycle,console:BucketReplication, orconsole:BucketEventspermissions can now access the respective tabs.🔄 Type of Change
🧪 Testing
Test Coverage
Test Results
Translation Script:
node translate-locales.jssuccessfully in Node.js 16 environment.zh-CN,ja-JP, etc., were correctly identified and translated.Permission Control:
pages/buckets/[key].vueensureshasPermissionis called for Lifecycle, Replication, and Events tabs.hasPermissioncorrectly handlesisAdmin,consoleAdmin, and specific scope grants.Result
# Lint check passed pnpm lint:fix📊 Performance Impact
🔒 Security Considerations
Note: This change improves security compliance by enforcing the Principle of Least Privilege (PoLP) in the UI, allowing non-admin users to manage specific bucket features if granted explicit permission.
📚 Documentation
✅ Checklist
Code Quality
Testing
Dependencies
Compatibility
🔗 Related Issues
Closes #
Fixes #
Related to #
📸 Screenshots (if applicable)
🚀 Deployment Notes
👥 Reviewers
Please review: @
📝 Additional Notes
The
translate-locales.jsscript changes are dev-tooling only and do not affect the runtime application, but ensure language packs are accurate for the release.