Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds focused parser coverage for the noun-first
lsaliases introduced with the recent bucket/object command groups.Problem
The command-group work in #76 added
bucketandobjectentrypoints withlsas an alias forlist, but the parser tests incrates/cli/src/commands/mod.rsdid not assert those alias routes. That left a small regression window where the alias wiring could drift without a fast unit test catching it.Root cause
Existing parser coverage around the noun-first surface focused on
bucket corsand other follow-up gaps, but not on thelsaliases attached directly toBucketCommands::ListandObjectCommands::List.Fix
The patch keeps scope tight to
crates/cli/src/commands/mod.rs:cli_accepts_bucket_list_aliasforrc bucket ls local/cli_accepts_object_list_aliasforrc object ls local/my-bucket/logs/Both assertions verify clap dispatch reaches the expected noun-first command variants and preserves the parsed path.
Validation
I ran:
cargo test -p rustfs-cli cli_accepts_bucket_list_alias --lib -- --nocapturecargo test -p rustfs-cli cli_accepts_object_list_alias --lib -- --nocapturecargo fmt --all --checkcargo clippy --workspace -- -D warningscargo test --workspaceI also ran
make pre-commitper the automation instructions, but this checkout does not define that target: