Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds focused regression coverage for an untested
rmparser path introduced by the recent remove-command changes.Users can pass malformed paths like
/bucket/keytorc rm. Before this change, the parser accepted that shape, produced an empty alias, and only failed later during alias lookup. That surfaced the wrong class of error and left the path-validation contract under-tested.Root cause
parse_rm_path()validated the bucket segment but did not reject an empty alias segment. Existing tests covered missing buckets and empty input, but they did not cover a leading slash path where the alias portion is blank.Fix
The patch keeps scope tight to
crates/cli/src/commands/rm.rs:parse_rm_path()/mybucket/file.txtThis keeps the failure at the parser boundary and prevents malformed remove paths from falling through into later alias resolution.
Validation
I ran:
cargo test -p rustfs-cli test_parse_rm_path_empty_alias --lib -- --nocapturecargo fmt --all --checkcargo clippy --workspace -- -D warningscargo test --workspaceI also ran
make pre-commitper the automation instructions, but this checkout does not define that target: