Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change adds focused coverage for the noun-first
rc object removeentrypoint in the recent versioned purge flow.The existing integration test for force-delete behavior only exercised
rc rm --purge. That covered the shared implementation, but it left the newerobject removecommand path unverified end to end. If that alias stopped wiringRmArgsthrough correctly, users invoking the documented noun-first command could silently lose permanent-delete behavior while the legacy path still passed.This patch keeps the scope narrow by updating the existing versioned-object purge integration test to perform the purge step through
rc object remove --purge --json. The surrounding assertions stay the same, so the test still proves that a normal delete leaves a delete marker while the purge path removes all versions.Validation
I could not run
make pre-commitbecause this repository does not contain aMakefileorpre-committarget. I ran the documented checks directly instead:cargo fmt --all --checkcargo clippy --workspace -- -D warningscargo test --workspacecargo test -p rustfs-cli --features integration --test integration version_operations::test_rm_purge_permanently_deletes_versioned_object -- --exact --nocaptureThe targeted integration test passes in this environment and skips cleanly when S3 test credentials are not configured.