Skip to content

chore: simplify template package names#127

Merged
chenjiahan merged 1 commit intomainfrom
chenjiahan/chore-sync-template-package-managers
Apr 14, 2026
Merged

chore: simplify template package names#127
chenjiahan merged 1 commit intomainfrom
chenjiahan/chore-sync-template-package-managers

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

Summary

  • replace the old rsbuild-* package names in the Biome, ESLint, and Prettier templates with shorter template package names
  • keep the generated template manifests aligned with the selected tool and variant names

Testing

  • pnpm test

Related Links

  • None

Copilot AI review requested due to automatic review settings April 14, 2026 10:59
@chenjiahan chenjiahan merged commit b0ab524 into main Apr 14, 2026
6 checks passed
@chenjiahan chenjiahan deleted the chenjiahan/chore-sync-template-package-managers branch April 14, 2026 11:01
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies the name fields inside the Biome, ESLint (per-variant), and Prettier template package.json files by removing the older rsbuild-* prefixes, aiming to keep template manifests aligned with tool/variant naming.

Changes:

  • Renamed template-prettier/package.json#name from rsbuild-prettierprettier.
  • Renamed template-biome/package.json#name from rsbuild-biomebiome.
  • Renamed ESLint variant template package names from rsbuild-eslint-*eslint-* across React/Vue/Svelte/Vanilla variants.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
template-prettier/package.json Simplifies the Prettier template package name.
template-biome/package.json Simplifies the Biome template package name.
template-eslint/react-ts/package.json Simplifies ESLint React TS template package name.
template-eslint/react-js/package.json Simplifies ESLint React JS template package name.
template-eslint/vue-ts/package.json Simplifies ESLint Vue TS template package name.
template-eslint/vue-js/package.json Simplifies ESLint Vue JS template package name.
template-eslint/svelte-ts/package.json Simplifies ESLint Svelte TS template package name.
template-eslint/svelte-js/package.json Simplifies ESLint Svelte JS template package name.
template-eslint/vanilla-ts/package.json Simplifies ESLint Vanilla TS template package name (but currently uses common naming).
template-eslint/vanilla-js/package.json Simplifies ESLint Vanilla JS template package name (but currently uses common naming).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -1,5 +1,5 @@
{
"name": "rsbuild-eslint-common-ts",
"name": "eslint-common-ts",
Copy link

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ESLint template variant folder is vanilla-ts (and the code refers to the variant name vanilla-ts), but this package.json name uses eslint-common-ts. For consistency with the other variants (eslint-react-ts, eslint-vue-ts, etc.) and with the variant identifier, consider renaming this to eslint-vanilla-ts (or otherwise aligning the naming scheme across variants).

Suggested change
"name": "eslint-common-ts",
"name": "eslint-vanilla-ts",

Copilot uses AI. Check for mistakes.
@@ -1,5 +1,5 @@
{
"name": "rsbuild-eslint-common-js",
"name": "eslint-common-js",
Copy link

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ESLint template variant folder is vanilla-js (and the code refers to the variant name vanilla-js), but this package.json name uses eslint-common-js. For consistency with the other variants (eslint-react-js, eslint-svelte-js, etc.) and with the variant identifier, consider renaming this to eslint-vanilla-js (or otherwise aligning the naming scheme across variants).

Suggested change
"name": "eslint-common-js",
"name": "eslint-vanilla-js",

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants