Rewatch: don't suppress progress messages under -v/-vv#8371
Merged
jfrolich merged 1 commit intorescript-lang:masterfrom Apr 19, 2026
Merged
Rewatch: don't suppress progress messages under -v/-vv#8371jfrolich merged 1 commit intorescript-lang:masterfrom
jfrolich merged 1 commit intorescript-lang:masterfrom
Conversation
Change show_progress from `log_level_filter == LevelFilter::Info` to `>= LevelFilter::Info` so that verbose flags (-v, -vv) add debug output without silencing progress messages like 'Finished compilation'.
cknitt
approved these changes
Apr 19, 2026
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change
show_progressfromlog_level_filter == LevelFilter::Infoto>= LevelFilter::Infoso that-v/-vvadd debug output without also silencing progress messages like "Finished compilation".Small UX fix split out of #8241.
Test plan
cargo build --release --manifest-path rewatch/Cargo.tomlrewatch buildwith and without-v/-vv, confirm progress line still prints at each verbosity🤖 Generated with Claude Code