Skip to content

Sync latest syntax.#5575

Merged
cristianoc merged 2 commits intomasterfrom
sync-latest-syntax
Jul 21, 2022
Merged

Sync latest syntax.#5575
cristianoc merged 2 commits intomasterfrom
sync-latest-syntax

Conversation

@cristianoc
Copy link
Copy Markdown
Collaborator

  • Initial support for JSX V4, still work in progress.
    • 💥 when V4 is activated, at most one component is allowed for each module.

match !Js_config.jsx_version with
| 3 -> Reactjs_jsx_ppx_v3.rewrite_signature ast
| 3 ->
Reactjs_jsx_ppx.rewrite_signature ~jsxVersion:3 ~jsxModule:""
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be duplicated to #5484

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to merge this in master.
Then #5484 rebases on top.
A small step, but gets the basic structure into master.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got your point!

@cristianoc cristianoc merged commit 724ee3d into master Jul 21, 2022
@cristianoc cristianoc deleted the sync-latest-syntax branch July 21, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants