fix(align): restore overflowX and overflowY after force align#615
fix(align): restore overflowX and overflowY after force align#615ffgenius wants to merge 1 commit intoreact-component:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Walkthrough
Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the useAlign hook to capture and restore overflowX and overflowY styles, preventing them from being lost during alignment. It also includes a test case to confirm the fix. A review comment suggests removing an unnecessary empty line to maintain consistent code formatting.
| const originOverflow = popupElement.style.overflow; | ||
| const originOverflowX = popupElement.style.overflowX; | ||
| const originOverflowY = popupElement.style.overflowY; | ||
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #615 +/- ##
==========================================
+ Coverage 97.26% 97.28% +0.01%
==========================================
Files 17 17
Lines 952 956 +4
Branches 274 278 +4
==========================================
+ Hits 926 930 +4
Misses 26 26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
solve ant-design/ant-design#57665
Summary by CodeRabbit
发布说明
Bug 修复
测试