Draft
Conversation
a8660d6 to
270b0cd
Compare
auguste-probabl
commented
Apr 9, 2026
| def test_no_response_method(self, fixture_name, request): | ||
| """Check that computing a custom metric without passing the | ||
| response method raises an error.""" | ||
| def test_summarize_single_list_equivalence(self, fixture_name, request): |
Collaborator
Author
There was a problem hiding this comment.
This test was done for every report, so I moved it here
270b0cd to
a89e767
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
This PR makes it possible to register a custom metric in an
EstimatorReport, so that it's shown along with the other default metrics insummarize:Closes #2061
Contribution checklist
to a preview of the documentation to review it visually)
requires updating tests)
AI usage disclosure
AI tools were involved for:
I had an LLM write down specs in docs/design, write some tests based on those specs, and some of the implementation.