phar: reject extractTo() when destination parent escapes via symlink#21808
Open
iliaal wants to merge 1 commit intophp:PHP-8.4from
Open
phar: reject extractTo() when destination parent escapes via symlink#21808iliaal wants to merge 1 commit intophp:PHP-8.4from
iliaal wants to merge 1 commit intophp:PHP-8.4from
Conversation
Phar::extractTo() builds the target path as dest + "/" + entry_path. CWD_EXPAND validates entry_path against ".." traversal but doesn't resolve symlinks. A pre-existing symlink in the destination (e.g., /dest/subdir -> /etc) writes the extracted file outside the intended root. After creating the parent directory, resolve it with VCWD_REALPATH and verify it stays under dest. Return FAILURE if it escapes so the caller throws a PharException.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes destination-side symlink traversal in
Phar::extractTo().extractTo()builds the target path asdest + "/" + entry_path.CWD_EXPANDvalidates the entry path against..traversal but doesn't resolve symlinks. A pre-existing symlink in the destination (e.g.,/dest/subdir -> /etc) causes the extracted file to land outside the intended root.After creating the parent directory, resolve it with
VCWD_REALPATHand verify it stays underdest. ReturnFAILUREif it escapes so the caller throws aPharException.The test skips on Windows only when
SeCreateSymbolicLinkPrivilegeis absent. Without it,symlink()returns false without error, so no symlink exists in the destination,extractTo()succeeds, and the test outputsEXTRACTED (unexpected)instead of thePharExceptionthat--EXPECTF--requires.