Add Npgsql and EFCore.PG as git submodules#458
Merged
roji merged 1 commit intonpgsql:mainfrom Apr 21, 2026
Merged
Conversation
Replace separate checkout steps in the build workflow with git submodules pointing to the latest stable releases (Npgsql v10.0.2, EFCore.PG v10.0.1). - Add Npgsql and EFCore.PG as git submodules - Update workflow checkout to use submodules: true - Remove separate Checkout Npgsql/EFCore.PG workflow steps - Remove repository_dispatch trigger (no longer needed) - Remove /Npgsql and /EFCore.PG from .gitignore Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR migrates the documentation build pipeline from separately checking out the Npgsql/EFCore.PG repositories during CI to using git submodules in the repo instead.
Changes:
- Add Npgsql and EFCore.PG as git submodules via a new
.gitmodulesfile. - Update the documentation build workflow to checkout submodules and remove the dedicated checkout steps for Npgsql/EFCore.PG.
- Remove
/Npgsqland/EFCore.PGfrom.gitignoreand drop therepository_dispatchtrigger from the workflow.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.gitmodules |
Declares Npgsql and EFCore.PG as submodules under the repo root. |
.gitignore |
Stops ignoring the submodule directories so they can be present in the working tree. |
.github/workflows/build-documentation.yml |
Switches to submodules: true, removes separate checkouts, and removes repository_dispatch trigger. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+3
to
+6
| url = https://github.com/npgsql/npgsql.git | ||
| [submodule "EFCore.PG"] | ||
| path = EFCore.PG | ||
| url = https://github.com/npgsql/Npgsql.EntityFrameworkCore.PostgreSQL.git |
There was a problem hiding this comment.
Building the docs runs dotnet build inside the submodule working trees, which will typically produce untracked bin//obj/ and leave the submodules in a dirty state in local dev checkouts. Consider adding ignore = dirty (or ignore = untracked) for these submodules in .gitmodules to reduce local workflow friction.
Suggested change
| url = https://github.com/npgsql/npgsql.git | |
| [submodule "EFCore.PG"] | |
| path = EFCore.PG | |
| url = https://github.com/npgsql/Npgsql.EntityFrameworkCore.PostgreSQL.git | |
| url = https://github.com/npgsql/npgsql.git | |
| ignore = dirty | |
| [submodule "EFCore.PG"] | |
| path = EFCore.PG | |
| url = https://github.com/npgsql/Npgsql.EntityFrameworkCore.PostgreSQL.git | |
| ignore = dirty |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace separate checkout steps in the build workflow with git submodules pointing to the latest stable releases (Npgsql v10.0.2, EFCore.PG v10.0.1).