Merged
Conversation
This smoke test will verify there's no errors being generated when running the build process. + minor package.json test script refactoring for increased readability
|
LGTM, merged! |
ghost
pushed a commit
that referenced
this pull request
Jan 11, 2016
Created smoke test for the build process
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This smoke test will verify there's no errors being generated when running the build process. The test simply executes
build.jsand asserts there were no errors raised from the child process. As most of the current code base lacks test coverage atm, this will hopefully provide some confidence that the build process will not explode - that has happened with more than once with incoming PRs.Also did some minor package.json test script refactoring for better readability.
What it would look like when running the tests and some bad SASS syntax error got introduced by accident:
Closes #225