Change http://nodejs.org/ to https://nodejs.org/#128
Merged
fhemberger merged 5 commits intonodejs:masterfrom Sep 13, 2015
bnoordhuis:http-to-https
Merged
Change http://nodejs.org/ to https://nodejs.org/#128fhemberger merged 5 commits intonodejs:masterfrom bnoordhuis:http-to-https
fhemberger merged 5 commits intonodejs:masterfrom
bnoordhuis:http-to-https
Conversation
Contributor
|
+1 |
Member
There was a problem hiding this comment.
Was this intentional? That site doesnt seem to work with HTTPS
Member
Author
There was a problem hiding this comment.
It wasn't. I'll undo that before landing.
Member
|
sgtm |
Contributor
There was a problem hiding this comment.
This redirects now to https://nodejs.org/static/images/logos/ and returns a 403 (directory index is forbidden).
https://nodejs.org/en/about/resources/ would be a better match, but direkt links to the logo files should still go to static/.
Contributor
|
A few URLs could point directly to the new locations, otherwise LGTM. |
Bulk update HTTP links to their HTTPS counterpart.
https://nodejs.org/logos/ is a redirect to https://nodejs.org/static/images/logos/ that 403s because directory listings are disabled. Link to https://nodejs.org/en/about/resources/.
https://nodejs.org/about/organization/ redirects to https://nodejs.org/en/about/organization/. Link directly to the latter and avoid an extra HTTP roundtrip.
The links weren't exactly dead but we can avoid the extra HTTP redirect roundtrip and link to the right section in one go.
The page lives at https://nodejs.org/en/about/advisory-board/ now.
Member
Author
|
Fixed up the links, PTAL. |
Contributor
|
+1 |
fhemberger
added a commit
that referenced
this pull request
Sep 13, 2015
Contributor
|
Great, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bulk update HTTP links to their HTTPS counterpart.