Skip to content

crypto: fix unsigned conversion of 4-byte RSA publicExponent #62839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deepview-autofix wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −1
Open

crypto: fix unsigned conversion of 4-byte RSA publicExponent #62839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/internal/crypto/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,7 @@ function bigIntArrayToUnsignedInt(input) {
result |= input[n] << 8 * n_reversed;
}

return result;
return result >>> 0;
}

function bigIntArrayToUnsignedBigInt(input) {
Expand Down
19 changes: 19 additions & 0 deletions test/parallel/test-webcrypto-util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,28 @@ if (!common.hasCrypto)
const assert = require('assert');

const {
bigIntArrayToUnsignedInt,
normalizeAlgorithm,
} = require('internal/crypto/util');

// bigIntArrayToUnsignedInt must return an unsigned 32-bit value even when
// the most significant byte has its top bit set. Otherwise the signed `<<`
// operator yields a negative Int32 for inputs like [0x80, 0x00, 0x00, 0x01].
{
assert.strictEqual(
bigIntArrayToUnsignedInt(new Uint8Array([0x80, 0x00, 0x00, 0x01])),
0x80000001);
assert.strictEqual(
bigIntArrayToUnsignedInt(new Uint8Array([0xff, 0xff, 0xff, 0xff])),
0xffffffff);
assert.strictEqual(
bigIntArrayToUnsignedInt(new Uint8Array([1, 0, 1])),
65537);
assert.strictEqual(
bigIntArrayToUnsignedInt(new Uint8Array([1, 0, 0, 0, 0])),
undefined);
}

{
// Check that normalizeAlgorithm does not mutate object inputs.
const algorithm = { name: 'ECDSA', hash: 'SHA-256' };
Expand Down
Loading