Merged
Conversation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #43658
To-dos:
Moduleserialisation issue (Proxies aren’t serialisable)import.meta.resolve()to synchronousNotable changes:
Custom ESM loader hooks run on dedicated thread
ESM hooks supplied via loaders (
--experimental-loader=./foo.mjs) now run in a dedicated thread, isolated from the main thread. This provides a separate scope for loaders and ensures no cross-contamination between loaders and application code. A few things to know:globalPreloadhook’sport. Global variables are not shared between scopes.Synchronous
import.meta.resolve()In alignment with browser behavior, this function now returns synchronously. Despite this, user loader
resolvehooks can still be defined as async functions (or as sync functions, if the author prefers). Even when there are asyncresolvehooks loaded,import.meta.resolvewill still return synchronously for application code.Contributed by Anna Henningsen, Antoine du Hamel, Geoffrey Booth, Guy Bedford, Jacob Smith, and Michaël Zasso in #44710