flaky: parallel.test-child-process-fork-net

[mhdawson]

Test

parallel.test-child-process-fork-net

Platform

Windows

Console output

Add description
Error Message
fail (1)
Stacktrace
---
duration_ms: 567.994
exitcode: 1
severity: fail
...

Build links

• https://ci.nodejs.org/job/node-test-binary-windows-js-suites/25880/RUN_SUBSET=1,nodes=win11-COMPILED_BY-vs2022/testReport/junit/(root)/parallel/test_child_process_fork_net/

Additional information

No response

[joyeecheung]

This has failed 14 PRs out of the last 100 CI runs.

From a glance the test it's hard to tell what it is trying to do. It was added by dceebbf#diff-53a1141f9d431cc7d603359ba604d660819f5560b68895fb639dc988a34644c8 so I suppose the original intention was just to test that the socket can be sent over to the child. The messages based on connection order seems to be very brittle, I don't think we guarantee that if you fork multiple child processes, they are going to be ready to connect to the parent in the exact same order that you start them. Perhaps the test can be split so that each child process gets its own test. But that's just a guess, I am not 100% that's not breaking what the test was trying to check.

[joyeecheung]

Actually I have a different theory. See #51841

[lpinca]

Fixed in #51841.