doc: active module page not highlighted in sidebar nav

[DerekNonGeneric]

📗 API Reference Docs Problem

• Version: n/a (current master branch)

• Platform: n/a

• Subsystem: docs

Location

Section of the site where the content exists

Affected URL(s):

• http://localhost:8000/api/module.html

Description

Concise explanation of the problem

See the title of the issue as is self-explanatory.

Working

Non-working

This was introduced relatively recently and probably has to do w/ the fact that there are <code> tags in there.

/cc @aduh95 as is most likely the most familiar w/ this problem

---

• I would like to work on this issue and
  submit a pull request.

[aduh95]

Good catch! So I dig a bit into it, the issue comes from the fact that modules.html link comes before module.html in the list, and it transform the class attribute of the wrong element.

Expected

<li><a href="modules.html" class="nav-modules">Modules: CommonJS modules</a></li>
<li><a href="esm.html" class="nav-esm">Modules: ECMAScript modules</a></li>
<li><a href="module.html" class="nav-module active">Modules: <code>module</code> API</a></li>

Actual

<li><a href="modules.html" class="nav-module actives">Modules: CommonJS modules</a></li>
<li><a href="esm.html" class="nav-esm">Modules: ECMAScript modules</a></li>
<li><a href="module.html" class="nav-module">Modules: <code>module</code> API</a></li>

Patch incoming!