Compiling 10.15.3 failing intermittently in custom build steps

[danielgindi]

• Version: 10.15.3
• Platform: Windows x64

Running vcbuild.bat on a clean clone - fails, due to obj/global_intermediate/node_protocol.pdl not existing, or other such file in global_intermediate.
A second run on vcbuild.bat succeeds!

I've narrowed it down to the default /m:2.
The custom build steps in the vcxproj are not configured in a way that they depend on each other. The only dependency defined is their order in the project file, and they are configured as single items in the project with a custom build step on each of them.

The result is that with multiple CLs running, the ordering is messed up. Because the factor is 2 concurrent CLs, a second run always succeeds.

I've also tried a workaround with NUMBER_OF_PROCESSORS=1 in the env, but the shell does not allow such an override.

[bnoordhuis]

@danielgindi Can you check if #27026 fixes the issue for you? Thanks.

[danielgindi]

@bnoordhuis that did it! thanks :-)
will this be backported to 10.x (or even 10.15.3)?

[danielgindi]

@bnoordhuis You might want to gitignore: src/inspector/node_protocol.json

[danielgindi]

@bnoordhuis Sorry, but it still fails occassionaly:

  v8_inspector_compress_protocol_json
  Traceback (most recent call last):
    File "tools\compress_json.py", line 15, in <module>
      fp = open(sys.argv[1])
  IOError: [Errno 2] No such file or directory: 'C:\\Users\\DANIEL~1.SIL\\AppData\\Local\\Temp\\gxQEEFVlmG053ZmQZIQe\\n
  ode\\Release\\obj\\global_intermediate\\concatenated_protocol.json'