Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis is a Changesets-generated release PR bumping all workspace packages to
Confidence Score: 4/5Merging will publish packages with breaking changes under a minor version, misleading semver consumers — hold until bump types are corrected. Two P1 findings: public SDK packages with explicitly documented breaking API changes are versioned as minor rather than major. All other changes (private apps, CHANGELOG entries, non-breaking additions) are clean. packages/ensnode-sdk/package.json and packages/ensrainbow-sdk/package.json — both require a major version bump to reflect their breaking API changes. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
CS[Changesets Release PR] --> SDK["@ensnode/ensnode-sdk\n1.10.1 → 1.11.0 (minor ⚠️)"]
CS --> RSDK["@ensnode/ensrainbow-sdk\n1.10.1 → 1.11.0 (minor ⚠️)"]
CS --> APPS[Private Apps\nensadmin / ensapi / ensindexer\n1.10.1 → 1.11.0]
CS --> PKGS[Other Packages\nenssdk / datasources / etc.\n1.10.1 → 1.11.0]
SDK -->|breaking changes| BC1["labelSet → clientLabelSet\nEnsRainbowVersionInfo replaces version\nrecordsCount removed"]
RSDK -->|breaking changes| BC2["labelSet → serverLabelSet\nversionInfo replaces version: string\nrecordsCount removed"]
SDK -->|new features| F1["replaceBigInts + toJson helpers\nEnsIndexerStackInfo / EnsNodeStackInfo models"]
BC1 -.->|should be| MAJOR1["major bump → 2.0.0"]
BC2 -.->|should be| MAJOR2["major bump → 2.0.0"]
Reviews (3): Last reviewed commit: "RELEASING: Releasing 23 package(s)" | Re-trigger Greptile |
github-actions
Bot
force-pushed
the
changeset-release/main
branch
from
8c08124 to
951bd5d
Compare
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Releases: @ensnode/ensrainbow-sdk@1.11.0 @ensnode/ensnode-sdk@1.11.0 ensadmin@1.11.0 @ensnode/integration-test-env@1.11.0 @docs/ensnode@1.11.0 ensapi@1.11.0 ensindexer@1.11.0 ensrainbow@1.11.0 fallback-ensapi@1.11.0 @namehash/ens-referrals@1.11.0 @ensnode/ensdb-sdk@1.11.0 @ensnode/ensnode-react@1.11.0 @namehash/namehash-ui@1.11.0 @docs/ensrainbow@1.11.0 enssdk@1.11.0 enscli@1.11.0 enskit@1.11.0 ensskills@1.11.0 @ensnode/datasources@1.11.0 @ensnode/ponder-sdk@1.11.0 @ensnode/ponder-subgraph@1.11.0 @ensnode/shared-configs@1.11.0 @ensnode/enskit-react-example@0.0.3 [skip ci]
github-actions
Bot
force-pushed
the
changeset-release/main
branch
from
951bd5d to
84e86f5
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| "name": "@ensnode/ensnode-sdk", | ||
| "version": "1.10.1", | ||
| "version": "1.11.0", | ||
| "type": "module", |
There was a problem hiding this comment.
The CHANGELOG for @ensnode/ensnode-sdk@1.11.0 explicitly marks changes as Breaking — labelSet → clientLabelSet rename and recordsCount removal — yet the bump is minor (1.10.1 → 1.11.0). Both packages are at 1.x.x and publicly published, so semver requires a major bump (2.0.0) for breaking API changes. Consumers relying on the removed or renamed fields will silently break without any version-range signal to warn them.
| "name": "@ensnode/ensrainbow-sdk", | ||
| "version": "1.10.1", | ||
| "version": "1.11.0", | ||
| "type": "module", |
There was a problem hiding this comment.
Same issue as @ensnode/ensnode-sdk: @ensnode/ensrainbow-sdk@1.11.0 also contains the breaking EnsRainbowPublicConfig changes (versionInfo replacing version: string, serverLabelSet rename, recordsCount removal) yet bumps minor instead of major. This violates semver for a public 1.x.x package and will silently break consumers.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@ensnode/ensnode-sdk@1.11.0
Minor Changes
#1988
0d8a4b4Thanks @tk-o! - Breaking: Updated core ENSNode data models.EnsIndexerPublicConfiglabelSetfield toclientLabelSet.EnsRainbowApiClientOptionslabelSetfield toclientLabelSet.EnsRainbowPublicConfigversion: stringfield withversionInfo: EnsRainbowVersionInfo.labelSetfield toserverLabelSet.recordsCountfield fromEnsRainbowPublicConfig.#1988
0d8a4b4Thanks @tk-o! - Introduced a set of "stack info" data models:EnsIndexerStackInfo,EnsNodeStackInfo.#1978
0d64d9eThanks @shrugs! - AddedreplaceBigInts(sourced from@ponder/utils) andtoJsonhelpers to@ensnode/ensnode-sdk.toJsonnow takes an options object ({ pretty?: boolean }) withprettydefaulting tofalse— pass{ pretty: true }for indented output. Migrated all in-repo call sites and dropped the@ponder/utilsdependency fromensapi.Patch Changes
@ensnode/ensrainbow-sdk@1.11.0
Minor Changes
#1988
0d8a4b4Thanks @tk-o! - Breaking: Updated core ENSNode data models.EnsIndexerPublicConfiglabelSetfield toclientLabelSet.EnsRainbowApiClientOptionslabelSetfield toclientLabelSet.EnsRainbowPublicConfigversion: stringfield withversionInfo: EnsRainbowVersionInfo.labelSetfield toserverLabelSet.recordsCountfield fromEnsRainbowPublicConfig.Patch Changes
@namehash/ens-referrals@1.11.0
Patch Changes
0d8a4b4,0d8a4b4,0d64d9e]:@ensnode/ensdb-sdk@1.11.0
Patch Changes
0d8a4b4,0d8a4b4,0d64d9e]:enskit@1.11.0
Patch Changes
@ensnode/ensnode-react@1.11.0
Patch Changes
0d8a4b4,0d8a4b4,0d64d9e]:@namehash/namehash-ui@1.11.0
Patch Changes
0d8a4b4,0d8a4b4,0d64d9e]:@ensnode/datasources@1.11.0
enssdk@1.11.0
ensskills@1.11.0
@ensnode/ponder-sdk@1.11.0
@ensnode/ponder-subgraph@1.11.0
ensadmin@1.11.0
Minor Changes
#1988
0d8a4b4Thanks @tk-o! - Removed Records Count info from the ENSRainbow card UI on the Connection page.#1988
0d8a4b4Thanks @tk-o! - RenamedENSNodeConfig*components to follow theEnsNodeStackInfo*pattern.Patch Changes
0d8a4b4,0d8a4b4,0d64d9e]:ensapi@1.11.0
Patch Changes
#1978
0d64d9eThanks @shrugs! - AddedreplaceBigInts(sourced from@ponder/utils) andtoJsonhelpers to@ensnode/ensnode-sdk.toJsonnow takes an options object ({ pretty?: boolean }) withprettydefaulting tofalse— pass{ pretty: true }for indented output. Migrated all in-repo call sites and dropped the@ponder/utilsdependency fromensapi.Updated dependencies [
0d8a4b4,0d8a4b4,0d64d9e]:ensindexer@1.11.0
Patch Changes
#1978
0d64d9eThanks @shrugs! - AddedreplaceBigInts(sourced from@ponder/utils) andtoJsonhelpers to@ensnode/ensnode-sdk.toJsonnow takes an options object ({ pretty?: boolean }) withprettydefaulting tofalse— pass{ pretty: true }for indented output. Migrated all in-repo call sites and dropped the@ponder/utilsdependency fromensapi.Updated dependencies [
0d8a4b4,0d8a4b4,0d64d9e]:ensrainbow@1.11.0
Patch Changes
0d8a4b4,0d8a4b4,0d64d9e]:fallback-ensapi@1.11.0
Patch Changes
0d8a4b4,0d8a4b4,0d64d9e]:@docs/ensnode@1.11.0
Patch Changes
#1965
3facf20Thanks @sevenzing! - Moved docker-compose.yml file to separatedockerdirectory, updates docs and cicd-testsUpdated dependencies []:
@docs/ensrainbow@1.11.0
Patch Changes
@ensnode/enskit-react-example@0.0.3
Patch Changes
@ensnode/integration-test-env@1.11.0
Patch Changes
#1965
3facf20Thanks @sevenzing! - Moved docker-compose.yml file to separatedockerdirectory, updates docs and cicd-testsUpdated dependencies [
0d8a4b4,0d8a4b4,0d64d9e]:enscli@1.11.0
@ensnode/shared-configs@1.11.0