Add cancel button for task polling#1193
Open
Christian-Sidak wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Add cancel button for task polling#1193Christian-Sidak wants to merge 1 commit intomodelcontextprotocol:mainfrom
Christian-Sidak wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1039
When a tool is run as a task and the inspector polls for status, there is no way to cancel the polling loop. The "Run Tool" button is disabled while polling, leaving the user stuck waiting indefinitely if a task never completes.
This PR adds a "Cancel Polling" button that appears next to the disabled "Run Tool" button during active polling. Clicking it aborts the polling loop immediately using an
AbortController, and the tool result area displays a message indicating that polling was cancelled (the server-side task may still be running).Changes
client/src/App.tsx: Added anAbortControllerref to manage the polling lifecycle. The polling sleep is now cancellable via the abort signal. AcancelPollingcallback is passed toToolsTab.client/src/components/ToolsTab.tsx: Added an optionalcancelPollingprop and a red "Cancel Polling" button that renders when polling is active.Test plan