Quick Fix info inconsistent when offering to import a UMD declaration.

[aluanhaddad]

TypeScript Version: 2.4.0 / nightly (2.5.0-dev.20170816)

To Reproduce:

C:\Source\import-quick-fix-issue> npm install -D typescript@next
C:\Source\import-quick-fix-issue> tsc --init
C:\Source\import-quick-fix-issue> npm install --save lodash @types/lodash
C:\Source\import-quick-fix-issue> 'export const chain = _.chain;'> index.ts
C:\Source\import-quick-fix-issue> code-insiders .

Open in Visual Studio Code, move cursor to _, click the 💡, and observe that the following quick fix info is displayed

Expected behavior:
If --allowSyntheticDefaultImports is true the quick fix info remains the same and the result is

import _ from "lodash";
export const chain = _.chain;

If --allowSyntheticDefaultImports is false the quick fix info changes to

and the result is

import * as _ from "lodash";
export const chain = _.chain;

Actual behavior:

Regardless of the values specified for --module and --allowSyntheticDefaultImports, the quick fix info is always

and the result is always

import * as _ from "lodash";
export const chain = _.chain;

Ideal behavior: 😃

If --allowSyntheticDefaultImports is true the quick fix info remains the same and the result is

import _ from "lodash";
export const chain = _.chain;

If --allowSyntheticDefaultImports is false and --module is either commonjs, amd, or umd the quick fix info is changed to

and the result is

import _ = require("lodash");
export const chain = _.chain;

[mhegazy]

PRs welcomed.

[aluanhaddad]

In light of #19261, I want to try and take this on if you do not mind.

I would welcome suggestions about where to get started.

[mhegazy]

I suppose you will always make it ImportKind.Default if --allowSyntheticDefaults in https://github.com/Microsoft/TypeScript/blob/f8f662d0a197a2b5d276d3c4130ca52d74a1c1b2/src/services/codefixes/importFixes.ts#L641

[aluanhaddad]

Great, thank you.