Public plugin API module has no module-level contract documentation#3113
Open
huyhoang171106 wants to merge 1 commit intometabrainz:masterfrom
Open
Conversation
…tion Signed-off-by: Nguyen Huy Hoang <181364121+huyhoang171106@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds module-level contract documentation to picard.plugin3.api, clarifying that this module is the supported import surface for Plugin API v3 and that symbols in __all__ define the public plugin-facing contract.
Changes:
- Introduced a module docstring describing the stability/import contract for plugin authors.
- Documented the intended usage pattern (import from
picard.plugin3.api) and summarized exported symbols.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
picard/plugin3/api.pyis the public import surface for plugin authors (__all__defines the exposed API), but it has no module docstring documenting what is stable, how to import from it, or what each exported symbol represents. For an extension API, this increases misuse risk and creates support burden because plugin authors must inspect internals instead of relying on an explicit contract.Files changed
picard/plugin3/api.py(modified)Testing
Summary
Problem
Solution
AI Usage
In accordance with the AI use policy portion of the MetaBrainz Contribution Guidelines, the level of AI/LLM use in the development of this Pull Request is:
Action
Additional actions required: