chore(build): add Vercel preview builds for framework test apps by ShaneK · Pull Request #31073 · ionic-team/ionic-framework

ShaneK · 2026-04-09T19:20:21Z

Issue number: resolves internal

What is the current behavior?

Vercel preview deployments only build and serve core Stencil component test pages. Framework-specific test apps (Angular, React, Vue, React Router) are not included, requiring developers to pull and build locally to validate them.

What is the new behavior?

Vercel preview deployments build and serve framework test apps alongside core component tests under a single preview URL.

Does this introduce a breaking change?

Yes
No

Other information

vercel · 2026-04-09T19:20:33Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
ionic-framework	Ready	Preview, Comment	Apr 14, 2026 5:17pm

thetaPC

Mainly requesting for the sync command.

Question: Is it possible to add a way where we can determine if we want to build the frameworks? That way if we only need core then we don't have to wait for the others to build. It can be a label that is added to the PR or text command that is submitted through the comments, etc.

thetaPC · 2026-04-14T00:52:31Z

core/scripts/vercel-build.sh

+
+echo "=== Ionic Framework Preview Build ==="
+echo "Core dir: ${CORE_DIR}"
+echo "Repo root: ${REPO_ROOT:-NOT FOUND}"


We get a warning if REPO_ROOT is not found later in the script, I wonder if it would be beneficial if we can move it after this echo as to remind the dev that there is no need for concern.

thetaPC · 2026-04-14T00:59:48Z

core/scripts/vercel-build.sh

+build_angular_pkgs() {
+  (cd "${REPO_ROOT}/packages/angular" && npm install && npm run build) || return 1
+  (cd "${REPO_ROOT}/packages/angular-server" && npm install && npm run build) || return 1
+}
+
+build_react_pkgs() {
+  (cd "${REPO_ROOT}/packages/react" && npm install && npm run build) || return 1
+  (cd "${REPO_ROOT}/packages/react-router" && npm install && npm run build) || return 1
+}
+
+build_vue_pkgs() {
+  (cd "${REPO_ROOT}/packages/vue" && npm install && npm run build) || return 1
+  (cd "${REPO_ROOT}/packages/vue-router" && npm install && npm run build) || return 1
+}


These are missing the npm run sync command

Done, good catch!

thetaPC · 2026-04-14T01:02:03Z

core/scripts/vercel-build.sh

+
+build_angular_test() {
+  local APP
+  APP=$(pick_app "${REPO_ROOT}/packages/angular/test" ng20 ng19 ng18) || {


Is it possible to make this dynamic? We would have to manually update the versions otherwise.

thetaPC · 2026-04-14T01:03:46Z

core/scripts/vercel-build.sh

+
+build_react_test() {
+  local APP
+  APP=$(pick_app "${REPO_ROOT}/packages/react/test" react19 react18) || {


Is it possible to make this dynamic? We would have to manually update the versions otherwise.

thetaPC · 2026-04-14T01:03:59Z

core/scripts/vercel-build.sh

+
+build_vue_test() {
+  local APP
+  APP=$(pick_app "${REPO_ROOT}/packages/vue/test" vue3) || {


Is it possible to make this dynamic? We would have to manually update the versions otherwise.

thetaPC · 2026-04-14T01:14:48Z

packages/react/test/base/src/App.tsx

 const App: React.FC = () => (
  <IonApp>
-    <IonReactRouter>
+    <IonReactRouter basename={import.meta.env?.BASE_URL?.replace(/\/$/, '') || undefined}>


It might be helpful to add a comment of why basename is added so we avoid removing it because we don't remember it's importance.

… selection

ShaneK · 2026-04-14T17:47:37Z

RE: Your review comment:

Not really, unfortunately. If we relied on code-based suggestion, we'd be building most of the time anyway (we need to build them all any time core changes). If we went the tag route, we'd have to make some annoying changes to Vercel, including giving it a GitHub token to read that I think. I'm pretty sure what it currently has access to isn't enough to pull labels like that.

ShaneK requested a review from a team as a code owner April 9, 2026 19:20

ShaneK requested a review from brandyscarney April 9, 2026 19:20

github-actions bot added the package: react @ionic/react package label Apr 9, 2026

ShaneK force-pushed the chore/vercel-previews branch from 3bbcabf to 5eb431e Compare April 9, 2026 19:23

github-actions bot added the package: core @ionic/core package label Apr 9, 2026

vercel bot had a problem deploying to Preview April 9, 2026 19:24 Failure

ShaneK force-pushed the chore/vercel-previews branch from 5eb431e to 91aa59e Compare April 9, 2026 19:27

vercel bot had a problem deploying to Preview April 9, 2026 19:28 Failure

ShaneK force-pushed the chore/vercel-previews branch from 91aa59e to e4f45f1 Compare April 9, 2026 19:33

vercel bot deployed to Preview April 9, 2026 19:35 View deployment

ShaneK force-pushed the chore/vercel-previews branch from e4f45f1 to e785090 Compare April 9, 2026 19:42

vercel bot deployed to Preview April 9, 2026 19:43 View deployment

ShaneK force-pushed the chore/vercel-previews branch from e785090 to 60b1804 Compare April 9, 2026 19:48

vercel bot deployed to Preview April 9, 2026 19:50 View deployment

ShaneK force-pushed the chore/vercel-previews branch from 60b1804 to b5c7660 Compare April 9, 2026 19:57

vercel bot deployed to Preview April 9, 2026 20:01 View deployment

ShaneK force-pushed the chore/vercel-previews branch from b5c7660 to 2e41f54 Compare April 9, 2026 20:05

vercel bot deployed to Preview April 9, 2026 20:10 View deployment

ShaneK force-pushed the chore/vercel-previews branch from 2e41f54 to 192f551 Compare April 9, 2026 20:12

vercel bot deployed to Preview April 9, 2026 20:17 View deployment

ShaneK force-pushed the chore/vercel-previews branch from 192f551 to 99f295a Compare April 9, 2026 20:39

vercel bot deployed to Preview April 9, 2026 20:44 View deployment

chore(build): add Vercel preview builds for framework test apps

5f78b43

ShaneK force-pushed the chore/vercel-previews branch from 99f295a to 5f78b43 Compare April 9, 2026 20:57

vercel bot deployed to Preview April 9, 2026 21:02 View deployment

thetaPC requested changes Apr 14, 2026

View reviewed changes

chore(build): fix Vercel preview build with sync step and dynamic app…

ab81a78

… selection

vercel bot deployed to Preview April 14, 2026 17:17 View deployment

ShaneK requested a review from thetaPC April 14, 2026 17:47

Conversation

ShaneK commented Apr 9, 2026

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

Other information

Uh oh!

vercel bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thetaPC left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ShaneK commented Apr 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel bot commented Apr 9, 2026 •

edited

Loading