feat: add author affiliation in serializer#10549
Merged
jennifer-richards merged 3 commits intoietf-tools:mainfrom Mar 14, 2026
Merged
feat: add author affiliation in serializer#10549jennifer-richards merged 3 commits intoietf-tools:mainfrom
jennifer-richards merged 3 commits intoietf-tools:mainfrom
Conversation
This was referenced Mar 14, 2026
ietf/api/serializers_rpc.py
Outdated
| def get_plain_name(self, document_author: DocumentAuthor) -> str: | ||
| return document_author.person.plain_name() | ||
|
|
||
| def get_affiliation(self, document_author: DocumentAuthor) -> str: |
Member
There was a problem hiding this comment.
This should not be needed, just adding affiliation to fields ought to deal with all the workings. Did you try that?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10549 +/- ##
==========================================
- Coverage 88.39% 88.36% -0.03%
==========================================
Files 326 327 +1
Lines 43813 44092 +279
==========================================
+ Hits 38730 38964 +234
- Misses 5083 5128 +45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jennifer-richards
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.