feat: use RfcAuthor for red API#10014
Merged
jennifer-richards merged 3 commits intoietf-tools:feat/rpc-apifrom Nov 27, 2025
Merged
feat: use RfcAuthor for red API#10014jennifer-richards merged 3 commits intoietf-tools:feat/rpc-apifrom
jennifer-richards merged 3 commits intoietf-tools:feat/rpc-apifrom
Conversation
Import from serializers, not from fields
holloway
approved these changes
Nov 27, 2025
Contributor
holloway
left a comment
There was a problem hiding this comment.
Looks good, assuming that get_absolute_url does return a path and not a full url
Member
Author
Yes, it returns only the path. I don't know why it's named that way but it's Django's convention. (We supply the method so it won't change on us.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the
RfcAuthorschema to match theRfcAuthormodel and returns data fromdoc.rfcauthor_setif that is not empty. Otherwise, it usesdoc.documentauthor_setdata. The same serialized schema is used regardless of the data source.The new schema is below. Note that
titlepage_nameis the only guaranteed non-empty field. This is the only name field included - the oldnamefield has been dropped. A newdatatracker_person_pathfield is added. This is the URL path for the author's "person page", relative to datatracker's root. If this is empty, no link should be rendered.When representing a
DocumentAuthor:titlepage_namewill beperson.plain_name()(same value as thenamefield prior to this refactor)is_editoris alwaysFalsepersonis always non-null