fix(cache): log "caches is not defined" only once#4871
Open
yuintei wants to merge 1 commit intohonojs:mainfrom
Open
fix(cache): log "caches is not defined" only once#4871yuintei wants to merge 1 commit intohonojs:mainfrom
yuintei wants to merge 1 commit intohonojs:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4871 +/- ##
=======================================
Coverage 92.89% 92.89%
=======================================
Files 177 177
Lines 11797 11801 +4
Branches 3515 3514 -1
=======================================
+ Hits 10959 10963 +4
Misses 837 837
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Hi @yuintei This PR is not bad. BUT, the |
yuintei
added a commit
to yuintei/hono-cache-log-repro
that referenced
this pull request
Apr 12, 2026
Contributor
Author
Member
|
Thank you for the response and repro! I considered that declaring the variable with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The log is repeated for every
cache()call whenglobalThis.cachesis not available. This PR ensures the message is logged only once.The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code