Move implicit majyk inside 'Client.__init__'.#956
Merged
tseaver merged 2 commits intogoogleapis:masterfrom Jul 2, 2015
tseaver:944-client_ctor_defaults
Merged
Move implicit majyk inside 'Client.__init__'.#956tseaver merged 2 commits intogoogleapis:masterfrom tseaver:944-client_ctor_defaults
tseaver merged 2 commits intogoogleapis:masterfrom
tseaver:944-client_ctor_defaults
Conversation
googlebot
added
the
cla: yes
8 tasks
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
This seems pretty straightforward, thanks for making the change tiny and digestible :) LGTM other than the comments I've already made. |
tseaver
added a commit
that referenced
this pull request
Jul 2, 2015
Move implicit majyk inside 'Client.__init__'.
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Closes #955. Co-authored-by: Bu Sun Kim <busunkim@google.com>
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
* feat: Add field information when raising validation errors. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix: Fix string formatting error --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Nov 25, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Nov 26, 2025
* Make code changes in _default * Add unit tests. * Fix docstring. Co-authored-by: arithmetic1728 <58957152+arithmetic1728@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Mar 6, 2026
* refactor: extract common logic to TableBase class * Adress pytype's missing attribute false warning * Mark TableBase class as private * Simplify TableReference.to_api_repr() logic * Avoid get/set subproperty helper gotcha * Test _TableBase class directly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #944.