Skip to content

chore: complete migration of pandas-gbq#16707

Open
jskeet wants to merge 1 commit intogoogleapis:mainfrom
jskeet:generate-pandas-gbq
Open

chore: complete migration of pandas-gbq#16707
jskeet wants to merge 1 commit intogoogleapis:mainfrom
jskeet:generate-pandas-gbq

Conversation

@jskeet
Copy link
Copy Markdown
Contributor

@jskeet jskeet commented Apr 17, 2026

Removed skip_generate and regenerated with Librarian.

Removed skip_generate and regenerated with Librarian.
@jskeet jskeet requested review from a team as code owners April 17, 2026 05:44
@jskeet jskeet requested review from TrevorBergeron and removed request for a team April 17, 2026 05:44
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables generation for the pandas-gbq library by removing the skip_generate flag in librarian.yaml and updates the .repo-metadata.json file with alphabetically sorted keys. Feedback indicates that the codeowner_team field was removed during the metadata update and should be restored to maintain automation for PR assignments.

Comment on lines 3 to +4
"client_documentation": "https://googleapis.dev/python/pandas-gbq/latest/",
"distribution_name": "pandas-gbq",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The codeowner_team field was removed during the regeneration process. This field is important for identifying the teams responsible for this package and is used by automation for PR assignments. Please restore it while maintaining the alphabetical order of the keys.

Suggested change
"client_documentation": "https://googleapis.dev/python/pandas-gbq/latest/",
"distribution_name": "pandas-gbq",
"client_documentation": "https://googleapis.dev/python/pandas-gbq/latest/",
"codeowner_team": "@googleapis/cloud-sdk-python-team @googleapis/bigquery-dataframe-team",
"distribution_name": "pandas-gbq",

@chalmerlowe
Copy link
Copy Markdown
Contributor

@jskeet I don't yet know what the cause is, but for the life of me, I could not get the pandas-gbq prerelease to complete in one of my PRs. The logs die part way through the run, so I was never able to see what the cause was.

I looked at your logs for unittest/prerelease and they are identical to what I was seeing in other PRs. If I find a solution I will let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants