chore: complete migration of google-cloud-ndb#16702
Conversation
This isn't a generated API, so the .repo-metadata.json is all that will change.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the configuration for the google-cloud-ndb library by removing the skip_generate flag in librarian.yaml and reordering keys in .repo-metadata.json. Feedback indicates that the codeowner_team field was unintentionally deleted during the metadata reordering and should be restored. Additionally, the removal of skip_generate should be reconsidered as it may conflict with the manual nature of the library.
| "api_shortname": "datastore", | ||
| "client_documentation": "https://googleapis.dev/python/python-ndb/latest", | ||
| "distribution_name": "google-cloud-ndb", | ||
| "issue_tracker": "https://github.com/googleapis/python-ndb/issues", | ||
| "release_level": "stable", | ||
| "language": "python", | ||
| "library_type": "GAPIC_MANUAL", | ||
| "repo": "googleapis/google-cloud-python", | ||
| "distribution_name": "google-cloud-ndb", | ||
| "default_version": "", | ||
| "codeowner_team": "@googleapis/firestore-dpe @googleapis/gcs-sdk-team", | ||
| "api_shortname": "datastore" | ||
| } | ||
| "name": "python-ndb", | ||
| "name_pretty": "NDB Client Library for Google Cloud Datastore", | ||
| "release_level": "stable", | ||
| "repo": "googleapis/google-cloud-python" |
There was a problem hiding this comment.
The codeowner_team field was removed during the alphabetical reordering of keys. This field is required for tracking package ownership and routing issues to the correct teams. Please restore it.
"api_shortname": "datastore",
"client_documentation": "https://googleapis.dev/python/python-ndb/latest",
"codeowner_team": "@googleapis/firestore-dpe @googleapis/gcs-sdk-team",
"distribution_name": "google-cloud-ndb",
"issue_tracker": "https://github.com/googleapis/python-ndb/issues",
"language": "python",
"library_type": "GAPIC_MANUAL",
"name": "python-ndb",
"name_pretty": "NDB Client Library for Google Cloud Datastore",
"release_level": "stable",
"repo": "googleapis/google-cloud-python"| - name: google-cloud-ndb | ||
| version: 2.4.2 | ||
| skip_generate: true | ||
| python: |
There was a problem hiding this comment.
The removal of skip_generate: true contradicts the pull request description which states that only .repo-metadata.json will change and that this is not a generated API. If this library is manual and should not be processed by the generator, this flag should be retained.
skip_generate: true
python:
This isn't a generated API, so the .repo-metadata.json is all that will change.
2 participants
This isn't a generated API, so the .repo-metadata.json is all that will change.