chore: complete gapic-generator migration#16679
chore: complete gapic-generator migration#16679jskeet wants to merge 2 commits intogoogleapis:mainfrom
Conversation
jskeet
commented
Apr 16, 2026
- Reformat with nox
- Enable generation with librarian
- Regenerate with librarian
|
@parthea Obviously this is a huge change - but it really is just running nox format. (Librarian doesn't actually "generate" this at all.) We could potentially remove the first commit, bringing it into librarian without reformatting - but if it is okay to reformat, I think it's worth doing. |
There was a problem hiding this comment.
Code Review
This pull request performs a comprehensive reformatting of the gapic-generator package and its integration test goldens, focusing on import organization, string quote standardization, and multi-line argument formatting. It also updates repository metadata and enables generation for the library by removing the skip_generate flag. I have no feedback to provide.
|
According to gemini, this is one of the fixes I may have some fixes already in googleapis/gapic-generator-python#2499. Let me know if you want to hand this over, and what command I should run to re-generate the code after applying the fix. |