feat(gooddata-sdk): [AUTO] Add AFM execution parameters, WhatIfScenario, and new filter types#1565
Open
yenkins-admin wants to merge 1 commit intomasterfrom
Open
feat(gooddata-sdk): [AUTO] Add AFM execution parameters, WhatIfScenario, and new filter types#1565yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
…io, and new filter types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added SDK wrappers for WhatIfScenario analysis (AfmWhatIfMeasureAdjustmentConfig, AfmWhatIfScenarioItem, AfmWhatIfScenarioConfig) and MetricDefinitionOverride support in ExecutionDefinition / compute_model_to_api_model. AllTimeDateFilter with emptyValueHandling and MatchAttributeFilter were already fully implemented. DashboardArbitraryAttributeFilter was determined to be a dashboard-context filter not requiring an SDK compute-layer wrapper. All new classes are exported from gooddata_sdk.init. Unit tests added for all new classes.
Impact: new_feature | Services:
gooddata-afm-client,gooddata-metadata-clientTickets: CQ-2056
Files changed
packages/gooddata-sdk/src/gooddata_sdk/compute/model/what_if.pypackages/gooddata-sdk/src/gooddata_sdk/compute/model/execution.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/compute_model/test_metric_definition_override.pyAgent decisions
Decisions (4)
MetricDefinitionOverride placement — Placed in execution.py alongside ExecutionDefinition
WhatIf class naming with Afm prefix — AfmWhatIfMeasureAdjustmentConfig / AfmWhatIfScenarioItem / AfmWhatIfScenarioConfig
_check_type=False on AFM model constructor — Added _check_type=False to models.AFM() call in compute_model_to_api_model
DashboardArbitraryAttributeFilter not wrapped — No SDK wrapper added
Assumptions to verify (3)
Risks (2)
Layers touched (3)
packages/gooddata-sdk/src/gooddata_sdk/compute/model/what_if.pypackages/gooddata-sdk/src/gooddata_sdk/compute/model/execution.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/compute_model/test_metric_definition_override.pySource commits (gdc-nas)
c9c966bMerge pull request #21589 from gooddata/dho/cq-2114-flag7f74f3eMerge pull request #21535 from gooddata/dho/cq-2114-execution-context0468f7fMerge pull request #21536 from gooddata/dho/cq-2114-propaf3e42dMerge pull request #21504 from gooddata/dho/cq-2114-automation-filtersf21d1fcMerge pull request #21527 from pmsgd/pms/cq-20567382d93Merge pull request #21572 from gooddata/CQ-2056-2cf171aeMerge pull request #21497 from pmsgd/pms/cq-4951a3380fMerge pull request #21235 from pmsgd/pms/cq-2030OpenAPI diff
Workflow run
Generated by SDK OpenAPI Sync workflow