Skip to content

Add Ruby as a fully-supported model editor language #3584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koesie10 merged 1 commit into from
Apr 30, 2024
Merged

Add Ruby as a fully-supported model editor language #3584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions extensions/ql-vscode/src/model-editor/supported-languages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { QueryLanguage } from "../common/query-language";
import type { ModelConfig } from "../config";
import { isCanary } from "../config";

/**
* Languages that are always supported by the model editor. These languages
Expand All @@ -9,6 +8,7 @@ import { isCanary } from "../config";
export const SUPPORTED_LANGUAGES: QueryLanguage[] = [
QueryLanguage.Java,
QueryLanguage.CSharp,
QueryLanguage.Ruby,
];

export function isSupportedLanguage(
Expand All @@ -19,11 +19,6 @@ export function isSupportedLanguage(
return true;
}

if (language === QueryLanguage.Ruby) {
// Ruby is only enabled when in canary mode
return isCanary();
}

if (language === QueryLanguage.Python) {
// Python is only enabled when the config setting is set
return modelConfig.enablePython;
Expand Down