Display "result format" dropdown in results view for (path-)problem queries#2745
Merged
shati-patel merged 2 commits intomainfrom Aug 25, 2023
Merged
Display "result format" dropdown in results view for (path-)problem queries#2745shati-patel merged 2 commits intomainfrom
shati-patel merged 2 commits intomainfrom
Conversation
ab4d375 to
f8d542d
Compare
This was referenced Aug 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For variant analyses with interpreted results (i.e. problem queries or path-problem queries), users should have the option to display raw results (see internal linked issue for details).
This PR adds the new dropdown from #2743 to the MRVA results view, but only for queries that have a
path-problemorproblemkind. (Otherwise there's only one display format anyway)Note: The dropdown currently has no effect 🙃 For the final piece of the puzzle, I'll open a PR that actually uses the result format to control the result display! (It's in progress, stay tuned 😎)
Checklist
N/A (I'll update the changelog in the final PR that strings things together)
ready-for-doc-reviewlabel there.