Skip to content

Update progress bar for "install pack dependencies"#1087

Merged
shati-patel merged 1 commit intogithub:mainfrom
shati-patel:packaging-progress
Jan 20, 2022
Merged

Update progress bar for "install pack dependencies"#1087
shati-patel merged 1 commit intogithub:mainfrom
shati-patel:packaging-progress

Conversation

@shati-patel
Copy link
Copy Markdown
Contributor

As @adityasharad suggested in #1076 (comment), we can have more granular progress tracking by counting how many packs to install 📦

This sort of works, except we can't set the maxStep until after the user has selected the packs... So for the first step (here) I just stuck with "2" as the max number of steps, which means that the first step takes up a disproportionate amount of space in the progress bar. This looks a bit odd, but I don't think it's a big problem 😅

Checklist

n/a - just a follow-up to #1076!

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • If this pull request makes user-facing changes that require documentation changes, the ready-for-doc-review label has been added to this pull request or the corresponding issue.

@shati-patel shati-patel marked this pull request as ready for review January 19, 2022 21:16
@shati-patel shati-patel requested a review from a team as a code owner January 19, 2022 21:16
@aeisenberg
Copy link
Copy Markdown
Contributor

So for the first step (here) I just stuck with "2" as the max number of steps, which means that the first step takes up a disproportionate amount of space in the progress bar.

There are similar issues with other progress bars, where we don't know the complete number of steps until later on. I don't think that's a problem we need to (or can) fix (at least without a lot of work).

@adityasharad
Copy link
Copy Markdown
Contributor

adityasharad commented Jan 19, 2022

The other alternative is adding some progress calls early to "complete" the progress bar once you work out the total number of steps, and then restart the progress bar for the variable steps (e.g. 1/2, 2/2, [work out the total number of steps], 1/total, 2/total, ..., total/total). It looks a bit odd in the UI and is...not really worth it 😆

@shati-patel shati-patel merged commit 068d461 into github:main Jan 20, 2022
@shati-patel shati-patel deleted the packaging-progress branch January 20, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants