Update progress bar for "install pack dependencies"#1087
Merged
shati-patel merged 1 commit intogithub:mainfrom Jan 20, 2022
Merged
Update progress bar for "install pack dependencies"#1087shati-patel merged 1 commit intogithub:mainfrom
shati-patel merged 1 commit intogithub:mainfrom
Conversation
aeisenberg
approved these changes
Jan 19, 2022
Contributor
There are similar issues with other progress bars, where we don't know the complete number of steps until later on. I don't think that's a problem we need to (or can) fix (at least without a lot of work). |
Contributor
|
The other alternative is adding some progress calls early to "complete" the progress bar once you work out the total number of steps, and then restart the progress bar for the variable steps (e.g. 1/2, 2/2, [work out the total number of steps], 1/total, 2/total, ..., total/total). It looks a bit odd in the UI and is...not really worth it 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @adityasharad suggested in #1076 (comment), we can have more granular progress tracking by counting how many packs to install 📦
This sort of works, except we can't set the
maxStepuntil after the user has selected the packs... So for the first step (here) I just stuck with "2" as the max number of steps, which means that the first step takes up a disproportionate amount of space in the progress bar. This looks a bit odd, but I don't think it's a big problem 😅Checklist
n/a - just a follow-up to #1076!
ready-for-doc-reviewlabel has been added to this pull request or the corresponding issue.