Skip to content

Update README.md#1102

Closed
cheftako wants to merge 1 commit intogithub:mainfrom
cheftako:patch-1
Closed

Update README.md#1102
cheftako wants to merge 1 commit intogithub:mainfrom
cheftako:patch-1

Conversation

@cheftako
Copy link
Copy Markdown

The viper binding at

_ = viper.BindPFlag("read-only", rootCmd.PersistentFlags().Lookup("read-only"))
means the environment flag is GITHUB_READ-ONLY not GITHUB_READ_ONLY. To be backward compatible I think we need to honor the flag as it works. So probably best to just fix the docs here.

The viper binding at https://github.com/github/github-mcp-server/blob/2a0c7bff82ea8d8f1d4999b3f222c8e8c13b05cc/cmd/github-mcp-server/main.go#L84 means the environment flag is GITHUB_READ-ONLY not GITHUB_READ_ONLY. To be backward compatible I think we need to honor the flag as it works. So probably best to just fix the docs here.
@cheftako cheftako requested a review from a team as a code owner September 19, 2025 16:22
@JoannaaKL
Copy link
Copy Markdown
Contributor

Hey @cheftako 👋 Viper configuration was updated yesterday and GITHUB_READ_ONLY will be honored link. In case of any questions please open an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants