[GHSA-q34c-v76q-8jx6] LedgerSMB does not set the 'Secure' attribute on the...#7365
Open
tjuyuxinzhang wants to merge 2 commits intotjuyuxinzhang/advisory-improvement-7365from
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Comments
This update corrects and improves the advisory based on the official LedgerSMB security advisory for CVE-2021-3882.
The affected version range has been corrected to 1.8.0 through 1.8.21 (inclusive), with version 1.8.22 as the first fixed release, as explicitly stated in the upstream advisory:
https://ledgersmb.org/cve-2021-3882-sensitive-non-secure-cookie
The same source also confirms that only the 1.8.x release line is affected, and that versions 1.7.x and 1.9.x are not impacted:
"Users of LedgerSMB 1.7 or 1.9 are unaffected by this vulnerability."
Additionally, the vulnerability description has been refined to align with the upstream explanation that the issue is caused by the absence of the 'Secure' attribute on session cookies when LedgerSMB is deployed behind a reverse proxy, enabling session hijacking via HTTP downgrade under specific conditions.
The attack scenario and impact have been updated based on the official advisory, which clearly states that:
These changes ensure the advisory is fully consistent with authoritative vendor documentation and accurately reflects the affected versions, root cause, and real-world exploitability.