feat(httpx): Migrate to span first#6084
Merged
ericapisani merged 10 commits intomasterfrom Apr 21, 2026
Merged
Conversation
Adds span streaming support to the httpx integration by adding a new
code path that uses `start_span` from `sentry_sdk.traces` when
`_experiments={"trace_lifecycle": "stream"}` is enabled. The existing
legacy path is preserved unchanged.
Test coverage is updated to:
- Rename span-data-asserting tests with a `_legacy` suffix
- Fix broken mock targets in duration threshold tests (`start_span` →
`legacy_start_span` after the rename introduced two names)
- Add `_span_streaming` variants for all tests that assert on span data,
using `capture_items("span")` and `span["attributes"]` instead of
`event["spans"][*]["data"]`
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 9.78s All tests are passing successfully. ❌ Patch coverage is 2.78%. Project has 15093 uncovered lines. Files with missing lines (3)
Generated by Codecov Action |
Contributor
Codecov Results 📊Generated by Codecov Action |
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
sentrivana
requested changes
Apr 17, 2026
Contributor
There was a problem hiding this comment.
TY! Left some comments, the gist:
- Any attributes we set on the span in streaming mode need to be in Sentry Conventions. I've tried to point out some that need changing but please go through the rest too and double check 🙏🏻
- I'd remove all of the
start_timestamp_monotonic_mschanges. I don't really see the benefit over just using thestart_timestampand removing it makes the new and oldadd_http_request_sourcesimilar enough that we can unify them.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Remove start_timestamp_monotonic_ns from StreamedSpan and NoOpStreamedSpan, and simplify the end timestamp fallback in add_http_request_source to use datetime.now(timezone.utc) directly. The monotonic-based calculation added complexity without meaningful benefit over the UTC fallback. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 19eeac5. Configure here.
sentrivana
approved these changes
Apr 21, 2026
Contributor
There was a problem hiding this comment.
Ty for making the changes 🙏🏻
Cursor left one more comment: #6084 (comment) Might make sense to harden the code path if an exception gets thrown from send with a finally: or something similar.
Looks great otherwise! Approving to not block this unnecessarily.
Wrap real_send in try/finally so span attributes (URL, method, etc.) are always flushed to the span. Previously an exception from real_send would leave the span with no attributes at all. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the httpx integration to the span-first (streaming span) architecture.
When
_experiments={"trace_lifecycle": "stream"}is enabled, the integrationnow uses
StreamedSpanviasentry_sdk.traces.start_spaninstead of the legacySpan-based (transactions) path. The legacy path remains unchanged for backwards compatibility.Supporting changes:
add_http_request_source_for_streamed_span()added totracing_utils— aStreamedSpan-compatible variant that must be called inside the span contextmanager so source data is attached before the span is flushed
add_source()updated to dispatch betweenset_data/set_attributedependingon span type
start_timestamp_monotonic_nsproperty added toStreamedSpanandNoOpStreamedSpanto support the request source duration threshold checkPart of the broader span-first integration migration.
Fixes PY-2330
Fixes #6028