Integration tests on DaprClient responses by seherv · Pull Request #981 · dapr/python-sdk

seherv · 2026-04-15T13:54:51Z

Description

Tests the gRPC channel created by DaprClient directly, instead of asserting on the log outputs of the examples like in the PR that removes Mechanical Markdown (#977).

The old log assertions are kept as "documentation tests".

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #972

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Code compiles correctly
Created/updated tests
Extended the documentation

codecov · 2026-04-15T14:07:13Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.53%. Comparing base (bffb749) to head (e1521b5).
⚠️ Report is 113 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #981      +/-   ##
==========================================
- Coverage   86.63%   81.53%   -5.11%     
==========================================
  Files          84      139      +55     
  Lines        4473    13525    +9052     
==========================================
+ Hits         3875    11027    +7152     
- Misses        598     2498    +1900

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

This PR migrates example validation away from mechanical-markdown by introducing two pytest suites: (1) stdout-based “documentation” tests that run the examples and assert expected output, and (2) SDK-based integration tests that assert directly on DaprClient responses.

Changes:

Replace mechanical-markdown validation with pytest in tox -e examples (stdout assertions).
Add tox -e integration suite with a Dapr sidecar test harness and SDK-level assertions.
Update CI workflow and contributor docs to reflect the new testing approach.

Reviewed changes

Copilot reviewed 49 out of 49 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
tox.ini	Switch examples validation to pytest; add integration env
.github/workflows/validate_examples.yaml	Run both examples + integration in CI
pyproject.toml	Add pytest marker registration
examples/validate.sh	Remove mechanical-markdown entrypoint
README.md	Update developer instructions (examples/integration)
AGENTS.md	Update guidance for example validation workflow
examples/AGENTS.md	Update example validation documentation
CLAUDE.md	Add repo coding/style guidance
examples/conversation/real_llm_providers_example.py	Update output text
tests/clients/test_conversation_helpers.py	Docstring wording tweak
tests/examples/conftest.py	Add `DaprRunner` helper + `example_dir` fixture
tests/examples/test_configuration.py	Stdout-based example test
tests/examples/test_conversation.py	Stdout-based example test
tests/examples/test_crypto.py	Stdout-based example test
tests/examples/test_demo_actor.py	Stdout-based example test
tests/examples/test_distributed_lock.py	Stdout-based example test
tests/examples/test_error_handling.py	Stdout-based example test
tests/examples/test_grpc_proxying.py	Stdout-based example test
tests/examples/test_invoke_binding.py	Stdout-based example test
tests/examples/test_invoke_custom_data.py	Stdout-based example test
tests/examples/test_invoke_http.py	Stdout-based example test
tests/examples/test_invoke_simple.py	Stdout-based example test
tests/examples/test_jobs.py	Stdout-based example test
tests/examples/test_langgraph_checkpointer.py	Stdout-based example test
tests/examples/test_metadata.py	Stdout-based example test
tests/examples/test_pubsub_simple.py	Stdout-based example test
tests/examples/test_pubsub_streaming.py	Stdout-based example test
tests/examples/test_pubsub_streaming_async.py	Stdout-based example test
tests/examples/test_secret_store.py	Stdout-based example test
tests/examples/test_state_store.py	Stdout-based example test
tests/examples/test_state_store_query.py	Stdout-based example test
tests/examples/test_w3c_tracing.py	Stdout-based example test
tests/examples/test_workflow.py	Stdout-based example test
tests/integration/conftest.py	Add `DaprTestEnvironment` harness for SDK tests
tests/integration/secrets.json	Local secret store test data
tests/integration/test_configuration.py	SDK-based configuration tests
tests/integration/test_distributed_lock.py	SDK-based lock tests
tests/integration/test_invoke.py	SDK-based invocation tests
tests/integration/test_metadata.py	SDK-based metadata tests
tests/integration/test_pubsub.py	SDK-based pub/sub delivery tests
tests/integration/test_secret_store.py	SDK-based secret store tests
tests/integration/test_state_store.py	SDK-based state store tests
tests/integration/apps/invoke_receiver.py	gRPC app for invoke tests
tests/integration/apps/pubsub_subscriber.py	Subscriber app persisting received events
tests/integration/components/configurationstore.yaml	Redis configuration component
tests/integration/components/localsecretstore.yaml	Local-file secret store component
tests/integration/components/lockstore.yaml	Redis lock component
tests/integration/components/pubsub.yaml	Redis pubsub component
tests/integration/components/statestore.yaml	Redis state component

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 48 out of 48 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 48 out of 48 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 48 out of 48 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 48 out of 48 changed files in this pull request and generated 8 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 48 out of 48 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 49 out of 49 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

sicoyle · 2026-04-20T18:56:22Z

just approved the workflows :)

sicoyle · 2026-04-21T13:55:53Z

workflows approved again @seherv :)

sicoyle · 2026-04-24T14:52:19Z

-        self._bg_process: subprocess.Popen[str] | None = None
-        self._bg_output_file: IO[str] | None = None
+    def __init__(self, default_components: Path = RESOURCES_DIR) -> None:
+        self._default_components = default_components


resources pls

sicoyle · 2026-04-24T14:52:27Z

+        http_port: int = 3500,
+        app_port: int | None = None,
+        app_cmd: str | None = None,
+        components: Path | None = None,


resources pls

Updates the requirements on [pyyaml](https://github.com/yaml/pyyaml) to permit the latest version. - [Release notes](https://github.com/yaml/pyyaml/releases) - [Changelog](https://github.com/yaml/pyyaml/blob/6.0.3/CHANGES) - [Commits](yaml/pyyaml@6.0.2...6.0.3) --- updated-dependencies: - dependency-name: pyyaml dependency-version: 6.0.3 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sam <sam@diagrid.io> Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>

Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>

This reverts commit df5b0fc. Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>

Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>

Updates the requirements on [pydantic](https://github.com/pydantic/pydantic) to permit the latest version. - [Release notes](https://github.com/pydantic/pydantic/releases) - [Changelog](https://github.com/pydantic/pydantic/blob/main/HISTORY.md) - [Commits](pydantic/pydantic@v2.0...v2.13.3) --- updated-dependencies: - dependency-name: pydantic dependency-version: 2.13.3 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>

Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>

sicoyle

thank you!

sicoyle requested a review from Copilot April 15, 2026 14:02

Copilot started reviewing on behalf of sicoyle April 15, 2026 14:03 View session

Copilot AI reviewed Apr 15, 2026

View reviewed changes

seherv force-pushed the grpc-tests branch from d3ca6d3 to 7c62a0b Compare April 17, 2026 12:33

seherv requested a review from Copilot April 17, 2026 12:34

Copilot started reviewing on behalf of seherv April 17, 2026 12:34 View session

Copilot AI reviewed Apr 17, 2026

View reviewed changes

Comment thread tests/integration/test_configuration.py

Comment thread tests/integration/test_pubsub.py Outdated

seherv requested a review from Copilot April 17, 2026 14:43

Copilot started reviewing on behalf of seherv April 17, 2026 14:44 View session

Copilot AI reviewed Apr 17, 2026

View reviewed changes

Comment thread tox.ini

Comment thread tests/integration/conftest.py

seherv requested a review from Copilot April 20, 2026 08:12

Copilot started reviewing on behalf of seherv April 20, 2026 08:13 View session

Copilot AI reviewed Apr 20, 2026

View reviewed changes

Comment thread README.md Outdated

Comment thread tox.ini

Comment thread tests/integration/conftest.py

Comment thread tests/integration/conftest.py Outdated

seherv requested a review from Copilot April 20, 2026 08:55

Copilot started reviewing on behalf of seherv April 20, 2026 08:55 View session

Copilot AI reviewed Apr 20, 2026

View reviewed changes

seherv requested a review from Copilot April 20, 2026 09:58

Copilot started reviewing on behalf of seherv April 20, 2026 09:58 View session

Copilot AI reviewed Apr 20, 2026

View reviewed changes

Comment thread tests/examples/test_langgraph_checkpointer.py Outdated

Comment thread tests/examples/test_workflow.py Outdated

Comment thread tests/examples/test_langgraph_checkpointer.py

seherv force-pushed the grpc-tests branch 2 times, most recently from 31dfad2 to 2a22fdf Compare April 20, 2026 11:57

seherv requested a review from Copilot April 20, 2026 11:57

Copilot started reviewing on behalf of seherv April 20, 2026 11:58 View session

Copilot AI reviewed Apr 20, 2026

View reviewed changes

Comment thread tox.ini Outdated

Comment thread tox.ini Outdated

Comment thread tox.ini Outdated

seherv marked this pull request as ready for review April 20, 2026 12:06

seherv requested review from a team as code owners April 20, 2026 12:06

sicoyle reviewed Apr 24, 2026

View reviewed changes

dependabot Bot and others added 22 commits April 24, 2026 17:09

Move old integration tests to examples/

ad71a50

Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>

Test DaprClient directly

2641734

Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>

Update docs to new test structure

24a13e6

Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>

Address Copilot comments (1)

ab3079c

Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>

Address Copilot comments (2)

f3cbbc0

Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>

Address Copilot comments (3)

0c75e47

Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>

Replace sleep() with polls when possible

dd955ce

Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>

Address Copilot comments (4)

95d9ca6

Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>

Address Copilot comments (5)

8537ae6

Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>

Update README to include both test suites

e28d279

Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>

Document wait_until() in AGENTS.md

7e75218

Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>

Update CLAUDE.md

c3536b0

Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>

Fix package name

06d1965

Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>

Clean up entire process group

b1da046

Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>

PR cleanup (1)

eb8c87a

Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>

Fix possible race running example test

bf190a6

Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>

Assert on pubsub smoke test

8be9c5e

Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>

Revert "Fix possible race running example test"

97a1c28

This reverts commit df5b0fc. Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>

Address PR feedback (2)

227821f

Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>

Rename all appareances of components to resources

aaa2bd8

Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>

seherv force-pushed the grpc-tests branch from be6f6f5 to aaa2bd8 Compare April 24, 2026 15:10

seherv added 2 commits April 24, 2026 17:11

Merge branch 'main' into grpc-tests

33f33f3

Rename components/ to resources/

e1521b5

Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>

sicoyle approved these changes Apr 24, 2026

View reviewed changes

sicoyle added this pull request to the merge queue Apr 24, 2026

Merged via the queue into dapr:main with commit e401e5c Apr 24, 2026
14 of 15 checks passed

Conversation

seherv commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issue reference

Checklist

Uh oh!

codecov Bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sicoyle commented Apr 20, 2026

Uh oh!

sicoyle commented Apr 21, 2026

Uh oh!

sicoyle Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

sicoyle Apr 24, 2026

Choose a reason for hiding this comment

seherv commented Apr 15, 2026 •

edited

Loading

codecov Bot commented Apr 15, 2026 •

edited

Loading