You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This seems to be a functional change and thus perhaps requires an LWG issue.
The 2nd template argument of constant_wrapper is possibly provided by the user (and thus can be a function type whatever c is), and the change will affect such (pathological, IMO) uses. Presumably these deduction guides should rely on constant_wrapper::value_type.
Concretely, the proposed change makes it invalid to use the deduction guide with constant_wrapper</* ... */, int()> because remove_pointer_t accepts non-pointers, but F* would fail deduction.
Concretely, the proposed change makes it invalid to use the deduction guide with constant_wrapper</* ... */, int()> because remove_pointer_t accepts non-pointers, but F* would fail deduction.
Then we got a bigger problem: function_ref(std::constant_wrapper<nullptr, int()>{}) can bypass the ctor's Mandates and break the class invariant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwgIssue must be reviewed by LWG.not-editorialIssue is not deemed editorial; the editorial issue is kept open for tracking.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.