Fix pg prototype pollution via server supplied column names#3656
Open
Fix pg prototype pollution via server supplied column names#3656
Conversation
Deploying node-postgres with
|
| Latest commit: |
81a97db
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4fd9a90c.node-postgres.pages.dev |
| Branch Preview URL: | https://fix-pg-prototype-pollution-v.node-postgres.pages.dev |
hjr3
force-pushed
the
fix-pg-prototype-pollution-via-server-supplied-column-names
branch
4 times, most recently
from
3c11cd8 to
f71b55c
Compare
charmander
requested changes
Apr 14, 2026
|
|
||
| parseRow(rowData) { | ||
| const row = { ...this._prebuiltEmptyResultObject } | ||
| const row = Object.assign(Object.create(null), this._prebuiltEmptyResultObject) |
Collaborator
There was a problem hiding this comment.
Backward compat break, and I don’t think it’s necessary as long as _prebuiltEmptyResultObject is built correctly.
Collaborator
Author
There was a problem hiding this comment.
yes, great point. reverted.
| } | ||
|
|
||
| this._prebuiltEmptyResultObject = { ...row } | ||
| this._prebuiltEmptyResultObject = Object.assign(Object.create(null), row) |
Collaborator
There was a problem hiding this comment.
Can be reverted, similar to previous comment. Only the initial const row = Object.create(null) is necessary.
| query.once('row', function (row) { | ||
| test('returned right columns', function () { | ||
| assert.deepStrictEqual(row, { name: row.name }) | ||
| assert.deepStrictEqual(Object.keys(row), ['name']) |
Collaborator
There was a problem hiding this comment.
& revert test loosening accordingly
Collaborator
Author
There was a problem hiding this comment.
for sure. i was fighting with test failures that were not matching my local. i never intended to keep this as-is. reverted
hjr3
force-pushed
the
fix-pg-prototype-pollution-via-server-supplied-column-names
branch
from
f71b55c to
81a97db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.