Skip to content

fix(openapi): Deduplicate error schemas and fix titles for codegen compatibility#2398

Merged
vdusek merged 7 commits intomasterfrom
fix/openapi-schema-titles-and-error-dedup
Apr 9, 2026
Merged

fix(openapi): Deduplicate error schemas and fix titles for codegen compatibility#2398
vdusek merged 7 commits intomasterfrom
fix/openapi-schema-titles-and-error-dedup

Conversation

@vdusek
Copy link
Copy Markdown
Contributor

@vdusek vdusek commented Apr 7, 2026

Summary

  • Extract reusable ErrorDetail schema referenced by all error responses (eliminates 14 duplicate inline error objects)
  • Fix 6 schema titles that didn't match component names (broke use_title_as_name codegen)
  • Use const instead of single-value enum in schedule action type fields
  • Add titles to inline schemas in RequestDraftDelete, DeletedRequest, and DecodeAndVerifyResponse
  • Also see the refactor: Update generated models and adapt to them apify-client-python#704

Test plan

  • CI passes
  • Python client models regenerate correctly

🤖 Generated with Claude Code

@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Apr 7, 2026
@vdusek vdusek self-assigned this Apr 7, 2026
@github-actions github-actions bot added this to the 138th sprint - Tooling team milestone Apr 7, 2026
@vdusek vdusek changed the title fix: deduplicate error schemas and fix titles for codegen compatibility fix(openapi): Deduplicate error schemas and fix titles for codegen compatibility Apr 7, 2026
@vdusek vdusek removed request for fnesveda and janbuchar April 7, 2026 13:54
@vdusek vdusek marked this pull request as draft April 7, 2026 13:54
@apify-service-account

This comment was marked as outdated.

@apify-service-account

This comment was marked as outdated.

@apify-service-account

This comment was marked as outdated.

@apify-service-account

This comment was marked as outdated.

@apify-service-account

This comment was marked as outdated.

@apify-service-account

This comment was marked as outdated.

…mpatibility

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vdusek vdusek force-pushed the fix/openapi-schema-titles-and-error-dedup branch from 87ffcd1 to 5ce05a6 Compare April 8, 2026 09:16
@apify-service-account

This comment was marked as outdated.

@apify-service-account

This comment was marked as outdated.

@apify-service-account

This comment was marked as outdated.

@apify-service-account

This comment was marked as outdated.

@vdusek vdusek marked this pull request as ready for review April 8, 2026 11:08
@apify-service-account

This comment was marked as outdated.

@vdusek vdusek requested review from Pijukatel and janbuchar April 8, 2026 11:13
@apify-service-account

This comment was marked as outdated.

@apify-service-account

This comment was marked as off-topic.

@apify-service-account

This comment was marked as outdated.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@apify-service-account

This comment was marked as outdated.

@apify-service-account

This comment was marked as outdated.

@vdusek vdusek requested a review from janbuchar April 8, 2026 13:17
@apify-service-account
Copy link
Copy Markdown

Preview for this PR was built for commit 9bc575fb and is ready at https://pr-2398.preview.docs.apify.com!

@apify-service-account
Copy link
Copy Markdown

The Python client model PR has been updated with the latest OpenAPI spec changes: apify/apify-client-python#704

@apify-service-account
Copy link
Copy Markdown

Preview for this PR was built for commit 3b28c7ae and is ready at https://pr-2398.preview.docs.apify.com!

@apify-service-account
Copy link
Copy Markdown

The Python client model PR has been updated with the latest OpenAPI spec changes: apify/apify-client-python#704

@vdusek vdusek merged commit ce24adf into master Apr 9, 2026
15 checks passed
@vdusek vdusek deleted the fix/openapi-schema-titles-and-error-dedup branch April 9, 2026 08:18
vdusek added a commit to apify/apify-client-python that referenced this pull request Apr 9, 2026
This PR updates the auto-generated Pydantic models based on OpenAPI specification changes in [apify-docs PR #2398](apify/apify-docs#2398).

## Summary

- Regenerated `_models.py` from updated OpenAPI spec
- Adapted resource clients to renamed/restructured models:
  - `TaskOptions` → `OptionalRunOptions`
  - `ScheduleCreateActions` → discriminated union in `ScheduleCreate`
  - `EnvVar` → `EnvVarRequest` for create/update requests

---------

Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants