input validation and removal of unsafe numeric parsing#628
Open
metsw24-max wants to merge 1 commit intoapache:trunkfrom
Open
input validation and removal of unsafe numeric parsing#628metsw24-max wants to merge 1 commit intoapache:trunkfrom
metsw24-max wants to merge 1 commit intoapache:trunkfrom
Conversation
Author
|
@notroj look into this |
Collaborator
|
I'll be brutally honest here @metsw24-max - the effect of these comments putting pressure on me to merge your patches is that I will trust you less, and take more time to review your work, not to merge them faster. You're a new contributor here, and we definitely appreciate your PRs. We're under high workload at the moment, give us time. |
Author
|
apologies for that i didn’t mean to put any pressure on the review process. I understand the workload and appreciate you taking the time to review. I will wait for your feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change hardens balancer-manager parameter handling by replacing permissive numeric parsing
atoi atofwith strict range-checked parsingIt ensures malformed or partially valid inputs are rejected instead of being silently coerced into valid values.