Skip to content

input validation and removal of unsafe numeric parsing#628

Open
metsw24-max wants to merge 1 commit intoapache:trunkfrom
metsw24-max:input-validation-balancer-manager
Open

input validation and removal of unsafe numeric parsing#628
metsw24-max wants to merge 1 commit intoapache:trunkfrom
metsw24-max:input-validation-balancer-manager

Conversation

@metsw24-max
Copy link
Copy Markdown

This change hardens balancer-manager parameter handling by replacing permissive numeric parsing atoi atof with strict range-checked parsing
It ensures malformed or partially valid inputs are rejected instead of being silently coerced into valid values.

@metsw24-max
Copy link
Copy Markdown
Author

@notroj look into this

@notroj
Copy link
Copy Markdown
Collaborator

notroj commented Apr 16, 2026

I'll be brutally honest here @metsw24-max - the effect of these comments putting pressure on me to merge your patches is that I will trust you less, and take more time to review your work, not to merge them faster. You're a new contributor here, and we definitely appreciate your PRs. We're under high workload at the moment, give us time.

@metsw24-max
Copy link
Copy Markdown
Author

apologies for that i didn’t mean to put any pressure on the review process. I understand the workload and appreciate you taking the time to review. I will wait for your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants