Skip to content

refactor(@schematics/angular): remove redundant withEventReplay from provideClientHydration#32996

Merged
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:with-event-reply
Apr 14, 2026
Merged

refactor(@schematics/angular): remove redundant withEventReplay from provideClientHydration#32996
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:with-event-reply

Conversation

@alan-agius4
Copy link
Copy Markdown
Collaborator

withEventReplay and incremental hydration are now enabled by default when using provideClientHydration().

Since incremental hydration automatically depends on and enables event replay, explicitly passing withEventReplay() is no longer necessary.

See: angular/angular#68114

…m `provideClientHydration`

`withEventReplay` and incremental hydration are now enabled by default when using `provideClientHydration()`.

Since incremental hydration automatically depends on and enables event replay, explicitly passing `withEventReplay()` is no longer necessary.

See: angular/angular#68114
@alan-agius4 alan-agius4 requested a review from clydin April 14, 2026 09:46
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Apr 14, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the withEventReplay call from the provideClientHydration provider in the Angular server schematic and updates the corresponding unit tests to reflect this change. I have no feedback to provide.

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 14, 2026
@alan-agius4 alan-agius4 merged commit 777dfdd into angular:main Apr 14, 2026
36 of 37 checks passed
@alan-agius4 alan-agius4 deleted the with-event-reply branch April 14, 2026 11:30
@alan-agius4
Copy link
Copy Markdown
Collaborator Author

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: @schematics/angular target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants