Ollama stall-timeout path panics on missing llm_request log file

[sunilkumarvalmiki]

Summary

providers::ollama::tests::test_stream_ollama_timeout_on_stall panics due to unwrap() when request log file path does not exist.

Environment

• Repo: aaif-goose/goose
• Commit tested: 3f5277538d5f6df1a88faca5e77cecc0ee208ae1 (origin/main)
• Host: macOS 26.4.1 (arm64)
• Date tested: 2026-04-11

Reproduction

source bin/activate-hermit
cargo test -p goose --lib providers::ollama::tests::test_stream_ollama_timeout_on_stall -- --exact

Expected

Timeout handling should return a recoverable error path (or structured failure) without panicking.

Actual

Panic at crates/goose/src/providers/ollama.rs:523:10:

called `Result::unwrap()` on an `Err` value: failed to open file .../state/logs/llm_request.<uuid>.jsonl: No such file or directory (os error 2)

Impact

• Hard panic in stall-timeout path
• Test instability and potential runtime crash when log directory/file is absent

Evidence

• Log excerpt: https://github.com/sunilkumarvalmiki/goose/blob/bughunt/evidence-20260411/.artifacts/bug-hunt-20260411_233319/issues/bug2_ollama_timeout_panic_excerpt.txt
• Screenshot:
• Evidence video (all bugs): https://github.com/raw/sunilkumarvalmiki/goose/bughunt/evidence-20260411/.artifacts/bug-hunt-20260411_233319/screenshots/bug-evidence-summary.mp4

[sunilkumarvalmiki]

Repro + fix validation (local branch, macOS)

I reproduced this exactly and validated a local fix.

Before

Command:

source bin/activate-hermit
GOOSE_PATH_ROOT="$(mktemp -d)" cargo test -p goose --lib providers::ollama::tests::test_stream_ollama_timeout_on_stall -- --exact --nocapture

Observed panic (unwrap() on missing state/logs/.../llm_request.*.jsonl) with exit code 101.

Fix applied locally

RequestLog::start now creates state/logs via fs_err::create_dir_all before opening the request log file.

After

• providers::ollama::tests::test_stream_ollama_timeout_on_stall passes with an empty GOOSE_PATH_ROOT.
• Added regression test providers::utils::tests::request_log_start_creates_missing_logs_directory.

Evidence

• Full evidence index: https://github.com/sunilkumarvalmiki/goose/blob/evidence/ollama-local-20260412/evidence/ollama-local-20260412/README.md
• Before panic excerpt: https://gist.githubusercontent.com/sunilkumarvalmiki/ab9af726ff43522c3c5b7e9e9ed9a728/raw/70db7ec980a0bb000dcbfe666a2c5cdc5e35b744/bug8485_before_excerpt.txt
• After test log: https://gist.githubusercontent.com/sunilkumarvalmiki/ab9af726ff43522c3c5b7e9e9ed9a728/raw/393bae19bb2c02fa254cf47279265cece7c0fcfa/bug8485_after.log
• Added regression-test log: https://gist.githubusercontent.com/sunilkumarvalmiki/ab9af726ff43522c3c5b7e9e9ed9a728/raw/bde12edeb48f7483bede9d9f24b6052e3287428c/bug8485_utils_after.log
• Before screenshot (PNG):
• After screenshot (PNG):
• Video rollup (MP4): bug-evidence-before-after.mp4
• Checksums: https://gist.githubusercontent.com/sunilkumarvalmiki/ab9af726ff43522c3c5b7e9e9ed9a728/raw/8811a013247a0464329600b6675fcadb6376ea61/sha256.txt