fix: correct release note generation for merged PRs#2167
Conversation
The release generator mixed raw conventional commits for changelog content with merge subjects for PR counts and contributor mentions, which made v4.10.2 undercount PRs and collapse contributors to the release-branch owner. This change extracts a deduped PR set, prefers GitHub PR/compare metadata for titles/authors/contributors, keeps a narrow git fallback, and makes the workflow publish only the custom release body. Constraint: Must keep the fix tightly scoped to release generation correctness Constraint: Release note generation must remain dependency-free Rejected: Keep parsing merge-subject branch owners | cannot recover actual PR authors on maintainer-owned release branches Rejected: Keep body_path plus generate_release_notes | duplicates and misaligns release content Confidence: high Scope-risk: narrow Directive: If a custom release body is provided, do not re-enable GitHub auto-notes without reconciling the two sources Tested: npm test -- --run src/__tests__/release-generation.test.ts Tested: npx eslint scripts/release.ts src/lib/release-generation.ts src/__tests__/release-generation.test.ts Tested: npx tsc --noEmit Tested: npx tsx scripts/release.ts 4.10.2 --dry-run Tested: gh compare/PR metadata replay for v4.10.1...v4.10.2 via src/lib/release-generation.ts Not-tested: Full GitHub Actions release workflow on a live tag
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
OMX review completed. Verified the fix stays tightly scoped to release generation correctness: PR-backed note assembly, contributor derivation from real metadata, release-PR filtering, and workflow de-duplication of custom notes vs GitHub auto-notes. CI is green. Merge-ready. — |
1 similar comment
|
OMX review completed. Verified the fix stays tightly scoped to release generation correctness: PR-backed note assembly, contributor derivation from real metadata, release-PR filtering, and workflow de-duplication of custom notes vs GitHub auto-notes. CI is green. Merge-ready. — |
|
OMX review completed. Verified the fix stays tightly scoped to release generation correctness: PR-backed note assembly, contributor derivation from real metadata, release-PR filtering, and workflow de-duplication of custom notes vs GitHub auto-notes. Full CI, including npm pack/install validation, is green. Merge-ready. — |
1 participant
Summary
generate_release_noteson top of the custombody_pathrelease bodyVerification
npm test -- --run src/__tests__/release-generation.test.tsnpx eslint scripts/release.ts src/lib/release-generation.ts src/__tests__/release-generation.test.tsnpx tsc --noEmitnpx tsx scripts/release.ts 4.10.2 --dry-runsrc/lib/release-generation.tsto confirm 10 user-facing PRs and contributorsblue-int,DdangJin,EthanJStark,tjsingleton,Yeachan-HeoNotes