This repository was archived by the owner on Jul 4, 2023. It is now read-only.
Fix: Doc for LockedDropout Input Shape#73
Merged
PetrochukM merged 2 commits intoPetrochukM:masterfrom May 5, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
=======================================
Coverage 94.15% 94.15%
=======================================
Files 57 57
Lines 1523 1523
=======================================
Hits 1434 1434
Misses 89 89
Continue to review full report at Codecov.
|
PetrochukM
approved these changes
Apr 29, 2019
Owner
PetrochukM
left a comment
PetrochukM
left a comment
There was a problem hiding this comment.
This looks great, thank you! I'll merge as soon as the tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LockedDrop applies the same dropout mask to every time step.
Based on the implementation, here, the input
xshould have shape[sequence length, batch size, rnn hidden size].That is, the first dimension should be
sequence length(time sequence). Then, whenmask.expand_as(x), we get the same mask for every time step.