Skip to content
This repository was archived by the owner on Jul 4, 2023. It is now read-only.

Update Encoder specification; Bump version to 0.4.1#69

Merged
PetrochukM merged 3 commits intomasterfrom
encoders
Apr 9, 2019
Merged

Update Encoder specification; Bump version to 0.4.1#69
PetrochukM merged 3 commits intomasterfrom
encoders

Conversation

@PetrochukM
Copy link
Copy Markdown
Owner

Updates:

  • enforce_reversible specification has changed from a function to a property.
  • spacy.batch_encode now consistently returns length along with the encoded object.
  • More code reuse through object orientated programming.
  • Loosened up the specification for Encoder to return objects rather than Tensors.

@PetrochukM PetrochukM changed the title Update encoders Update Encoder specification; Bump version to 0.4.1 Apr 9, 2019
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #69 into master will decrease coverage by 0.37%.
The diff coverage is 82.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
- Coverage   94.33%   93.95%   -0.38%     
==========================================
  Files          57       57              
  Lines        1518     1523       +5     
==========================================
- Hits         1432     1431       -1     
- Misses         86       92       +6
Impacted Files Coverage Δ
torchnlp/encoders/text/whitespace_encoder.py 100% <ø> (ø) ⬆️
torchnlp/encoders/label_encoder.py 94.11% <100%> (+1.52%) ⬆️
torchnlp/encoders/text/text_encoder.py 100% <100%> (ø) ⬆️
torchnlp/__init__.py 100% <100%> (ø) ⬆️
torchnlp/encoders/text/subword_encoder.py 97.43% <100%> (+0.21%) ⬆️
torchnlp/encoders/text/static_tokenizer_encoder.py 97.87% <100%> (+0.31%) ⬆️
torchnlp/encoders/text/treebank_encoder.py 70.58% <50%> (-8.36%) ⬇️
torchnlp/encoders/text/moses_encoder.py 66.66% <60%> (-8.34%) ⬇️
torchnlp/encoders/text/character_encoder.py 83.33% <66.66%> (-6.67%) ⬇️
torchnlp/encoders/text/delimiter_encoder.py 85.71% <66.66%> (-5.96%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d524a25...0cc8e16. Read the comment docs.

@PetrochukM PetrochukM merged commit c432c3e into master Apr 9, 2019
@PetrochukM PetrochukM deleted the encoders branch April 10, 2019 00:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants