fix: increase API timeout default from 900s to 1800s for slow-thinking models#3431
Merged
fix: increase API timeout default from 900s to 1800s for slow-thinking models#3431
Conversation
b4391bc to
9ca086c
Compare
…g models Models like GLM-5/5.1 can think for 15+ minutes. The previous 900s (15 min) default for HERMES_API_TIMEOUT killed legitimate requests. Raised to 1800s (30 min) in both places that read the env var: - _build_api_kwargs() timeout (non-streaming total timeout) - _call_chat_completions() write timeout (streaming connection) The streaming per-chunk read timeout (60s) and stale stream detector (180-300s) are unchanged — those are appropriate for inter-chunk timing.
9ca086c to
20c2aeb
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Models like GLM-5/5.1 can think for 15+ minutes. The previous
HERMES_API_TIMEOUTdefault of 900s (15 min) killed legitimate requests mid-thinking.Fix
Raise
HERMES_API_TIMEOUTdefault from 900s to 1800s (30 min) in both places that read the env var:_build_api_kwargs()— non-streaming total timeout_call_chat_completions()— streaming connection write timeoutStill configurable via
HERMES_API_TIMEOUTenv var.Unchanged
Test results
200 passed, 0 failures.