fix: update api_key in _try_activate_fallback for subagent auth#3103
Merged
fix: update api_key in _try_activate_fallback for subagent auth#3103
Conversation
When fallback activates (e.g. minimax → OpenRouter), self.provider, self.base_url, self.api_mode, and self._client_kwargs were all updated but self.api_key was not. delegate_tool.py reads parent_agent.api_key to pass credentials to child agents, so subagents inherited the stale pre-fallback key (e.g. a minimax key sent to OpenRouter), causing 401 Missing Authentication errors. Add self.api_key = ... in both the anthropic_messages and chat_completions branches of _try_activate_fallback().
|
outsourc-e
pushed a commit
to outsourc-e/hermes-agent
that referenced
this pull request
Mar 26, 2026
…Research#3103) When fallback activates (e.g. minimax → OpenRouter), self.provider, self.base_url, self.api_mode, and self._client_kwargs were all updated but self.api_key was not. delegate_tool.py reads parent_agent.api_key to pass credentials to child agents, so subagents inherited the stale pre-fallback key (e.g. a minimax key sent to OpenRouter), causing 401 Missing Authentication errors. Add self.api_key = ... in both the anthropic_messages and chat_completions branches of _try_activate_fallback().
StreamOfRon
pushed a commit
to StreamOfRon/hermes-agent
that referenced
this pull request
Mar 29, 2026
…Research#3103) When fallback activates (e.g. minimax → OpenRouter), self.provider, self.base_url, self.api_mode, and self._client_kwargs were all updated but self.api_key was not. delegate_tool.py reads parent_agent.api_key to pass credentials to child agents, so subagents inherited the stale pre-fallback key (e.g. a minimax key sent to OpenRouter), causing 401 Missing Authentication errors. Add self.api_key = ... in both the anthropic_messages and chat_completions branches of _try_activate_fallback().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When provider fallback activates (e.g. minimax → OpenRouter),
_try_activate_fallback()updatedself.provider,self.base_url,self.api_mode, andself._client_kwargs— but neverself.api_key.delegate_tool.py:186readsparent_agent.api_keyto pass credentials to child agents. After fallback, this returned the stale pre-fallback key (e.g. a minimax API key being sent to OpenRouter), causing401 Missing Authentication headererrors on all subagents.Fix
Add
self.api_key = ...in both branches of_try_activate_fallback():self.api_key = effective_keyself.api_key = fb_client.api_keyTest plan
test_run_agent.py: 199 passedtest_fallback_model.py: 27 passed